[PATCH v2 2/3] reset: imx7: Fix always writing bits as 0
From: l.stach@pengutronix.de (Lucas Stach)
Date: 2018-07-23 09:41:16
Also in:
linux-pci, linux-pm, lkml
As this doesn't depend on any other patch in this series, I think it would be fine if Philipp?takes this patch through the reset tree. Regards, Lucas Am Freitag, den 20.07.2018, 15:47 +0300 schrieb Leonard Crestez:
quoted hunk ↗ jump to hunk
Right now the only user of reset-imx7 is pci-imx6 and the reset_control_assert and deassert calls on pciephy_reset don't toggle the PCIEPHY_BTN and PCIEPHY_G_RST bits as expected. Fix this by writing 1 or 0 respectively. The reference manual is not very clear regarding SRC_PCIEPHY_RCR but for other registers like MIPIPHY and HSICPHY the bits are explicitly documented as "1 means assert, 0 means deassert". The values are still reversed for IMX7_RESET_PCIE_CTRL_APPS_EN.quoted
Signed-off-by: Leonard Crestez <redacted> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>--- ?drivers/reset/reset-imx7.c | 2 +- ?1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/reset/reset-imx7.c b/drivers/reset/reset-imx7.c index 4db177bc89bc..fdeac1946429 100644 --- a/drivers/reset/reset-imx7.c +++ b/drivers/reset/reset-imx7.c@@ -78,11 +78,11 @@ static struct imx7_src *to_imx7_src(struct reset_controller_dev *rcdev)?static int imx7_reset_set(struct reset_controller_dev *rcdev,quoted
? ??unsigned long id, bool assert)?{quoted
? struct imx7_src *imx7src = to_imx7_src(rcdev); ? const struct imx7_src_signal *signal = &imx7_src_signals[id]; - unsigned int value = 0; + unsigned int value = assert ? signal->bit : 0;?quoted
? switch (id) { ? case IMX7_RESET_PCIEPHY: ? /* ? ?* wait for more than 10us to release phy g_rst and