On Mon, Jul 23, 2018 at 9:12 AM, Peter Rosin [off-list ref] wrote:

On 2018-07-23 05:40, Manivannan Sadhasivam wrote:

quoted

+             /* Handle the remaining bytes which were not sent */
+             while (!(readl(i2c_dev->base + OWL_I2C_REG_FIFOSTAT) &
+                    OWL_I2C_FIFOSTAT_TFF) && i2c_dev->msg_ptr < msg->len) {

You moved the OWL_ line to the left instead of right, so this is still
misaligned and thus not helping the reader.

Guys, wouldn't be better to


while (i2c_dev->msg_ptr < msg->len) {
 u32 fifostat = readl();

 if (!(fifostat & ...))
 break;
...
}

?

Same for the other branch.

Yes, it's more LOCs, but less bikeshedding,

-- 
With Best Regards,
Andy Shevchenko