[PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi
From: broonie@kernel.org (Mark Brown)
Date: 2018-07-10 18:39:44
Also in:
linux-devicetree, linux-serial, linux-spi, lkml
On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote: This is mostly good, just a couple of small things:
+config SPI_AT91_USART + tristate "Atmel USART Controller SPI driver" + depends on HAS_DMA + depends on (ARCH_AT91 || COMPILE_TEST) + select MFD_AT91_USART
Why is this selecting rather than depending on the MFD like we normally do?
quoted hunk ↗ jump to hunk
@@ -0,0 +1,432 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Driver for AT91 USART Controllers as SPI + * + * Copyright (C) 2018 Microchip Technology Inc. + * Author: Radu Pirea <radu.pirea@microchip.com> + */
Please use C++ comments for the whole block so it looks a bit more intentional. Otherwise Reviwed-by: Mark Brown [off-list ref] -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180710/8d6520d9/attachment.sig>