[PATCH 3/4] drivers/bus: arm-cci: Use SPDX license information

STALE2956d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2018-06-27 · open the first message on its own page

[PATCH 3/4] drivers/bus: arm-cci: Use SPDX license information

From: Punit Agrawal <hidden>
Date: 2018-06-22 12:30:57

[ + alkml, will ]

Please make sure to cc linux-arm-kernel and the appropriate maintainers
(see scripts/get_maintainer.pl) for Arm related patches.

Mawanda Henry [off-list ref] writes:
SPDX licence header helps developers and machines to know the right
license governing a particular file
It's good practice to update the commit log if you change the
commit. Something like -

"While we are at it, also update the MODULE_LICENSE() to reflect the
license version - GPL v2"
Signed-off-by: Mawanda Henry <redacted>
With that change,

Acked-by: Punit Agrawal <redacted>
quoted hunk
---
 drivers/bus/arm-cci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index ab04201..4f92f39 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
+// SPDX-License-Identifier: GPL-2.0
 /*
  * CCI cache coherent interconnect driver
  *
@@ -575,5 +575,5 @@ EXPORT_SYMBOL_GPL(cci_probed);
 
 early_initcall(cci_init);
 core_initcall(cci_platform_init);
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("ARM CCI support");

[PATCH 3/4] drivers/bus: arm-cci: Use SPDX license information

From: Will Deacon <hidden>
Date: 2018-06-27 12:21:30

On Fri, Jun 22, 2018 at 01:30:57PM +0100, Punit Agrawal wrote:
[ + alkml, will ]

Please make sure to cc linux-arm-kernel and the appropriate maintainers
(see scripts/get_maintainer.pl) for Arm related patches.

Mawanda Henry [off-list ref] writes:
quoted
SPDX licence header helps developers and machines to know the right
license governing a particular file
It's good practice to update the commit log if you change the
commit. Something like -

"While we are at it, also update the MODULE_LICENSE() to reflect the
license version - GPL v2"
quoted
Signed-off-by: Mawanda Henry <redacted>
With that change,

Acked-by: Punit Agrawal <redacted>
Is there a v2 of this patch that I can pick up?

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help