Thread (22 messages) 22 messages, 4 authors, 2018-07-18

[PATCH RT] arm64: fpsimd: use a local_lock() in addition to local_bh_disable()

From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
Date: 2018-05-22 17:21:19
Also in: linux-rt-users, lkml

On 2018-05-22 13:10:04 [-0400], Steven Rostedt wrote:
On Thu, 17 May 2018 14:40:06 +0200
Sebastian Andrzej Siewior [off-list ref] wrote:
quoted
+static DEFINE_LOCAL_IRQ_LOCK(fpsimd_lock);
 /*
  * Update current's FPSIMD/SVE registers from thread_struct.
  *
@@ -594,6 +595,7 @@ int sve_set_vector_length(struct task_struct *task,
 	 * non-SVE thread.
 	 */
 	if (task == current) {
+		local_lock(fpsimd_lock);
 		local_bh_disable();
I'm surprised that we don't have a "local_lock_bh()"?
right. Like the last time when we introduced a global lock with no
locking context? 
-- Steve
quoted
 
 		task_fpsimd_save();
Sebastian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help