Hi Simon, Magnus,
The ROHM BD9571MWV PMIC on the Renesas Salvator-X(S) and ULCB
development boards supports DDR Backup Power, which means that the DDR
power rails can be kept powered while the main SoC is powered down.
This patch series is the DT counterpart of the series "[PATCH v2 0/4]
regulator: bd9571mwv: Add support for DDR backup mode" [1] and
"[PATCH/RFC 0/2] regulator: bd9571mwv: Add support for toggle power
switches" [2].
The first patch adds the missing device node for the BD9571 PMIC on the
ULCB boards, and can be applied immediately.
The last two patches add DDR Backup Mode configuration, and depend on
the DT bindings in the driver patch being accepted.
Changes compared to v2:
- Add support for ULCB,
- Add "rohm,rstbmode-level" for Salvator-X(S).
This has been tested on M3ULCB (thanks Jacopo!), and on Salvator-X(S).
For testing, driver and DTS patches are available in the
topic/bd9571-ddr-backup-mode-driver-v2 and
topic/bd9571-ddr-backup-mode-dt-v2 branches of my renesas-drivers git
repository at
git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git.
Thanks for your comments!
[1] https://lkml.org/lkml/2018/3/14/302
[2] https://lkml.org/lkml/2018/3/14/324
Geert Uytterhoeven (3):
arm64: dts: renesas: ulcb: Add BD9571 PMIC
arm64: dts: renesas: salvator-common: Configure PMIC for DDR Backup
Power
arm64: dts: renesas: ulcb: Configure PMIC for DDR Backup Power
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
arch/arm64/boot/dts/renesas/ulcb.dtsi | 31 ++++++++++++++++++++++++
2 files changed, 33 insertions(+)
--
2.7.4
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Add a device node for the ROHM BD9571MWV PMIC.
This was based on the example in the DT binding documentation, but using
IRQ0 instead of a GPIO interrupt, as that matches the schematics, and
because INTC-EX is a simpler block.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- New.
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
On the R-Car Starter Kit Premier/Pro, all of the DDR0, DDR1, DDR0C, and
DDR1C power rails need to be kept powered when backup mode is enabled.
Reflect this in the "rohm,ddr-backup-power" property for the BD9571MWV
PMIC node.
The accessory power switch (SW8) is a momentary switch, hense specify
"rohm,rstbmode-pulse".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- New.
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 2 ++
1 file changed, 2 insertions(+)
From: Sergei Shtylyov <hidden> Date: 2018-03-14 15:17:17
Hello!
On 03/14/2018 03:09 PM, Geert Uytterhoeven wrote:
quoted hunk
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
From: Simon Horman <horms@verge.net.au> Date: 2018-03-16 11:49:47
On Wed, Mar 14, 2018 at 06:17:17PM +0300, Sergei Shtylyov wrote:
Hello!
On 03/14/2018 03:09 PM, Geert Uytterhoeven wrote:
quoted
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
Hi Sergei,
On Wed, Mar 14, 2018 at 4:17 PM, Sergei Shtylyov
[off-list ref] wrote:
On 03/14/2018 03:09 PM, Geert Uytterhoeven wrote:
quoted
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
Because it's a small number?
Does it matter?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Sergei Shtylyov <hidden> Date: 2018-03-16 12:08:13
On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
quoted
quoted
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
From: Simon Horman <horms@verge.net.au> Date: 2018-03-26 09:06:25
On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:
On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
quoted
quoted
quoted
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
Hi Simon,
On Mon, Mar 26, 2018 at 11:06 AM, Simon Horman [off-list ref] wrote:
On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:
quoted
On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
quoted
quoted
quoted
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)
I think hex is preferable for the bit flags. Decimal makes one think it's something
else -- some magnitude, etc...
Geert, it seems that Rob Herring is of the same opinion.
Would you care to respin this series?
Sure, after the respun driver series has been accepted.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
From: Simon Horman <horms@verge.net.au> Date: 2018-03-27 08:17:16
On Mon, Mar 26, 2018 at 11:13:54AM +0200, Geert Uytterhoeven wrote:
Hi Simon,
On Mon, Mar 26, 2018 at 11:06 AM, Simon Horman [off-list ref] wrote:
quoted
On Fri, Mar 16, 2018 at 03:08:13PM +0300, Sergei Shtylyov wrote:
quoted
On 03/16/2018 03:00 PM, Geert Uytterhoeven wrote:
quoted
quoted
quoted
On Salvator-X(S), all of the DDR0, DDR1, DDR0C, and DDR1C power rails
need to be kept powered when backup mode is enabled. Reflect this in
the "rohm,ddr-backup-power" property for the BD9571MWV PMIC node.
The accessory power switch (SW23) is a toggle switch, hense specify
"rohm,rstbmode-level".
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Add rohm,rstbmode-level.
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 ++
1 file changed, 2 insertions(+)