# \[RFC PATCH v2 05/12\] sh: Don't pull in all of linux/bitops.h in asm/cmpxchg-xchg.h

- From: Will Deacon \<hidden\>
- Date: 2018-02-26 15:06:45 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2018/02/5215253
- Thread: https://ratatoskr.run/linux-arm-kernel/2018/02/5215246/t.md

```text
The sh implementation of asm/cmpxchg-xchg.h pulls in linux/bitops.h
so that it can refer to BITS_PER_BYTE. It also transitively relies on
this pulling in linux/compiler.h for READ_ONCE.

Replace the #include with asm-generic/bits.h and linux/compiler.h

Signed-off-by: Will Deacon <redacted>
---
 arch/sh/include/asm/cmpxchg-xchg.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/sh/include/asm/cmpxchg-xchg.h b/arch/sh/include/asm/cmpxchg-xchg.h
index 1e881f5db659..41c290efa3c4 100644
--- a/arch/sh/include/asm/cmpxchg-xchg.h
+++ b/arch/sh/include/asm/cmpxchg-xchg.h
@@ -8,7 +8,8 @@
  * This work is licensed under the terms of the GNU GPL, version 2.  See the
  * file "COPYING" in the main directory of this archive for more details.
  */
-#include <linux/bitops.h>
+#include <linux/compiler.h>
+#include <asm-generic/bits.h>
 #include <asm/byteorder.h>
 
 /*
-- 
2.1.4
```
