Re: [PATCH 2/4] arm64: add basic DTS for i.MX8MQ

Am Montag, den 22.01.2018, 16:11 +0100 schrieb Arnd Bergmann:

On Mon, Jan 22, 2018 at 3:47 PM, Shawn Guo [off-list ref]
wrote:

quoted

On Wed, Jan 17, 2018 at 07:32:42PM +0100, Lucas Stach wrote:

quoted

This adds the basic DTS for the i.MX8MQ.
For now only the following peripherals are supported:
- IOMUXC (pin controller)
- CCM (clock controller)
- GPIO
- UART
- uSDHC (SD/eMMC controller)
- FEC (ethernet controller)
- i2c

This is enough to get a very basic board support up and running.

One known limitation is that the driver for the GPC interrupt
controller is still missing, rendering the CPU sleep states
unusable
as there is nothing waking them up anymore. This will be fixed in
due course.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
?arch/arm64/boot/dts/Makefile?????????????|???1 +
?arch/arm64/boot/dts/nxp/imx8mq-pinfunc.h | 632
+++++++++++++++++++++++++++++++
?arch/arm64/boot/dts/nxp/imx8mq.dtsi??????| 418
++++++++++++++++++++

So we will have the following two folders for SoCs from the same
company.

?arch/arm64/boot/dts/nxp/
?arch/arm64/boot/dts/freescale/

It might get worse once the sale to Qualcomm goes through and maybe
if
Broadcom makes another bid for Qualcomm in a few years ;-)

quoted

I'm a bit uncomfortable with that.??@Arnd, do you have an opinion
how we
should handle them?

It's a recurring problem of course. I have a small preference for
just adding
the i.mx files to arch/arm64/boot/dts/freescale/, but I'd leave it up
to you.

The nice thing about the split into Freescale/NXP is that it nicely
separates the Layerscape and i.MX stuff, which are two quite different
architectures. But that's just a nice coincidence and I'll happily
rework the patches to whatever suits the maintainers most. Please make
a judgement call.

Regards,
Lucas

On Mon, Jan 22, 2018 at 06:50:21PM +0100, Lucas Stach wrote:

The nice thing about the split into Freescale/NXP is that it nicely
separates the Layerscape and i.MX stuff, which are two quite different
architectures.

With more and more IPs shared between Layerscape and i.MX, the boundary
of these two architectures becomes blurry.

But that's just a nice coincidence and I'll happily
rework the patches to whatever suits the maintainers most. Please make
a judgement call.

Let's put them into 'freescale' folder.  Thanks.

Shawn