DORMANTno replies

[PATCH] ARM: kprobes: fix gcc-7 build warning

From: arnd@arndb.de (Arnd Bergmann)
Date: 2018-01-24 21:04:51
Also in: lkml
Subsystem: arm port, the rest · Maintainers: Russell King, Linus Torvalds

Recent versions of binutils always warn about test-arm.s:

arch/arm/probes/kprobes/test-arm.s:18262: Warning: using r15 results in unpredictable behaviour
arch/arm/probes/kprobes/test-arm.s:18337: Warning: using r15 results in unpredictable behaviour

We could work around this using the __inst_arm() macro for passing
the two instruction as a hexadecimal literal number, but as Ard
pointed out, there is no reason to leave the warnings enabled for
this file in general, we intentionally test for an instruction that
is not recommended to be used.

For consistency, this turns off the warning in both the ARM and Thumb2
versions of this file.

Suggested-by: Ard Biesheuvel <redacted>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/probes/kprobes/Makefile | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/arch/arm/probes/kprobes/Makefile b/arch/arm/probes/kprobes/Makefile
index 14db56f49f0a..6432578fc74b 100644
--- a/arch/arm/probes/kprobes/Makefile
+++ b/arch/arm/probes/kprobes/Makefile
@@ -11,3 +11,7 @@ obj-$(CONFIG_KPROBES)		+= actions-arm.o checkers-arm.o
 obj-$(CONFIG_OPTPROBES)		+= opt-arm.o
 test-kprobes-objs		+= test-arm.o
 endif
+
+# don't warn about intentionally bogus instructions
+CFLAGS_test-arm.o		+= -Wa,--no-warn
+CFLAGS_test-thumb.o		+= -Wa,--no-warn
-- 
2.9.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help