Possible bug in Armada-37xx pincontroller
From: Henrik Juul Pedersen <hidden>
Date: 2017-11-06 14:12:33
Also in:
linux-gpio
Hi, After some review of a current Armada 37xx design, we stumbled upon some pin numbering, which seems doubly-defined, and doesn't seem to follow the documentation available to us. We haven't gotten our hardware yet, so we haven't been able to test it, but the following patch is as we believe it should be defined. Best regards, Henrik Juul Pedersen LIAB ApS ---
diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.cb/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c index 71b944748304..e223fac20993 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c@@ -157,8 +157,8 @@ static struct armada_37xx_pin_grouparmada_37xx_nb_groups[] = {
PIN_GRP_GPIO("pwm1", 12, 1, BIT(4), "pwm"),
PIN_GRP_GPIO("pwm2", 13, 1, BIT(5), "pwm"),
PIN_GRP_GPIO("pwm3", 14, 1, BIT(6), "pwm"),
- PIN_GRP_GPIO("pmic1", 17, 1, BIT(7), "pmic"),
- PIN_GRP_GPIO("pmic0", 16, 1, BIT(8), "pmic"),
+ PIN_GRP_GPIO("pmic1", 7, 1, BIT(7), "pmic"),
+ PIN_GRP_GPIO("pmic0", 6, 1, BIT(8), "pmic"),
PIN_GRP_GPIO("i2c2", 2, 2, BIT(9), "i2c"),
PIN_GRP_GPIO("i2c1", 0, 2, BIT(10), "i2c"),
PIN_GRP_GPIO("spi_cs1", 17, 1, BIT(12), "spi"),