Thread (11 messages) 11 messages, 7 authors, 2017-11-30

[PATCH] rtc: add mxc driver for i.MX53

From: Patrick Brünn <hidden>
Date: 2017-11-30 14:24:27
Also in: linux-devicetree, linux-rtc, lkml

From: Philippe Ombredanne [mailto:pombredanne at nexb.com]
Sent: Donnerstag, 30. November 2017 15:00
On Thu, Nov 30, 2017 at 2:36 PM, Patrick Br?nn [off-list ref]
wrote:

Thomas:
I tend to prefer as Linus pointed the // style throughout when there
is only a license and copyright involved. Here this would mean:
quoted
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2004-2011 Freescale Semiconductor, Inc. All Rights
Reserved.

What's you take since you wrote the doc for this? And is there still
some updates needed for this since your last patch set?
While looking closer into different files I think it would become multiline again:
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Real Time Clock (RTC) Driver for i.MX53
+ * Copyright (c) 2004-2011 Freescale Semiconductor, Inc.
+ * Copyright (c) 2017 Beckhoff Automation GmbH & Co. KG
+ */
Patrick:
Side note a trailing  "All Rights Reserved." in a copyright statement
is never needed, even though customarily cargo culted by everyone,
including me.
Started in 1910, it become fully obsolete in 2000 thanks to Nicaragua
[1] signing the Berne convention.

[1] https://en.wikipedia.org/wiki/All_rights_reserved
Interessting. I just kept it because it was in the original file from freescale.
But with this background, I think it's fine to drop it, now.

Thanks,
Patrick
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help