[PATCH 0/2] Ux500 clock: Adjustments for three function implementations

STALE3241d

7 messages, 3 authors, 2017-11-14 · open the first message on its own page

[PATCH 0/2] Ux500 clock: Adjustments for three function implementations

From: SF Markus Elfring <hidden>
Date: 2017-09-27 18:45:43

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:40:20 +0200

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation in three functions
  Improve a size determination in three functions

 drivers/clk/ux500/clk-prcc.c    | 6 ++----
 drivers/clk/ux500/clk-prcmu.c   | 6 ++----
 drivers/clk/ux500/clk-sysctrl.c | 6 ++----
 3 files changed, 6 insertions(+), 12 deletions(-)

-- 
2.14.2

[PATCH 1/2] clk/ux500: Delete an error message for a failed memory allocation in three functions

From: SF Markus Elfring <hidden>
Date: 2017-09-27 18:47:18

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:23:58 +0200

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/clk/ux500/clk-prcc.c    | 4 +---
 drivers/clk/ux500/clk-prcmu.c   | 4 +---
 drivers/clk/ux500/clk-sysctrl.c | 4 +---
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/clk/ux500/clk-prcc.c b/drivers/clk/ux500/clk-prcc.c
index f50592775c9d..5ca07e6d1f64 100644
--- a/drivers/clk/ux500/clk-prcc.c
+++ b/drivers/clk/ux500/clk-prcc.c

@@ -108,10 +108,8 @@ static struct clk *clk_reg_prcc(const char *name,
 	}
 
 	clk = kzalloc(sizeof(struct clk_prcc), GFP_KERNEL);
-	if (!clk) {
-		pr_err("clk_prcc: %s could not allocate clk\n", __func__);
+	if (!clk)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	clk->base = ioremap(phy_base, SZ_4K);
 	if (!clk->base)

diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index 6e3e16b2e5ca..c137934f23ab 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c

@@ -259,10 +259,8 @@ static struct clk *clk_reg_prcmu(const char *name,
 	}
 
 	clk = kzalloc(sizeof(struct clk_prcmu), GFP_KERNEL);
-	if (!clk) {
-		pr_err("clk_prcmu: %s could not allocate clk\n", __func__);
+	if (!clk)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	clk->cg_sel = cg_sel;
 	clk->is_prepared = 1;

diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c
index 8a4e93ce1e42..e0a834c08a04 100644
--- a/drivers/clk/ux500/clk-sysctrl.c
+++ b/drivers/clk/ux500/clk-sysctrl.c

@@ -140,10 +140,8 @@ static struct clk *clk_reg_sysctrl(struct device *dev,
 	}
 
 	clk = devm_kzalloc(dev, sizeof(struct clk_sysctrl), GFP_KERNEL);
-	if (!clk) {
-		dev_err(dev, "clk_sysctrl: could not allocate clk\n");
+	if (!clk)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	/* set main clock registers */
 	clk->reg_sel[0] = reg_sel[0];

-- 
2.14.2

[PATCH 2/2] clk/ux500: Improve a size determination in three functions

From: SF Markus Elfring <hidden>
Date: 2017-09-27 18:48:28

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:30:53 +0200

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/clk/ux500/clk-prcc.c    | 2 +-
 drivers/clk/ux500/clk-prcmu.c   | 2 +-
 drivers/clk/ux500/clk-sysctrl.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/ux500/clk-prcc.c b/drivers/clk/ux500/clk-prcc.c
index 5ca07e6d1f64..7cfb59c9136d 100644
--- a/drivers/clk/ux500/clk-prcc.c
+++ b/drivers/clk/ux500/clk-prcc.c

@@ -107,7 +107,7 @@ static struct clk *clk_reg_prcc(const char *name,
 		return ERR_PTR(-EINVAL);
 	}
 
-	clk = kzalloc(sizeof(struct clk_prcc), GFP_KERNEL);
+	clk = kzalloc(sizeof(*clk), GFP_KERNEL);
 	if (!clk)
 		return ERR_PTR(-ENOMEM);

diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index c137934f23ab..9d1f2d4550ad 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c

@@ -258,7 +258,7 @@ static struct clk *clk_reg_prcmu(const char *name,
 		return ERR_PTR(-EINVAL);
 	}
 
-	clk = kzalloc(sizeof(struct clk_prcmu), GFP_KERNEL);
+	clk = kzalloc(sizeof(*clk), GFP_KERNEL);
 	if (!clk)
 		return ERR_PTR(-ENOMEM);

diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c
index e0a834c08a04..7c0403b733ae 100644
--- a/drivers/clk/ux500/clk-sysctrl.c
+++ b/drivers/clk/ux500/clk-sysctrl.c

@@ -139,7 +139,7 @@ static struct clk *clk_reg_sysctrl(struct device *dev,
 		return ERR_PTR(-EINVAL);
 	}
 
-	clk = devm_kzalloc(dev, sizeof(struct clk_sysctrl), GFP_KERNEL);
+	clk = devm_kzalloc(dev, sizeof(*clk), GFP_KERNEL);
 	if (!clk)
 		return ERR_PTR(-ENOMEM);

-- 
2.14.2

Re: [PATCH 1/2] clk/ux500: Delete an error message for a failed memory allocation in three functions

From: Ulf Hansson <hidden>
Date: 2017-09-28 16:04:02

On 27 September 2017 at 20:46, SF Markus Elfring
[off-list ref] wrote:

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:23:58 +0200

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>

Acked-by: Ulf Hansson <redacted>

quoted hunk

---
 drivers/clk/ux500/clk-prcc.c    | 4 +---
 drivers/clk/ux500/clk-prcmu.c   | 4 +---
 drivers/clk/ux500/clk-sysctrl.c | 4 +---
 3 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/clk/ux500/clk-prcc.c b/drivers/clk/ux500/clk-prcc.c
index f50592775c9d..5ca07e6d1f64 100644
--- a/drivers/clk/ux500/clk-prcc.c
+++ b/drivers/clk/ux500/clk-prcc.c

@@ -108,10 +108,8 @@ static struct clk *clk_reg_prcc(const char *name,
        }

        clk = kzalloc(sizeof(struct clk_prcc), GFP_KERNEL);
-       if (!clk) {
-               pr_err("clk_prcc: %s could not allocate clk\n", __func__);
+       if (!clk)
                return ERR_PTR(-ENOMEM);
-       }

        clk->base = ioremap(phy_base, SZ_4K);
        if (!clk->base)

diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index 6e3e16b2e5ca..c137934f23ab 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c

@@ -259,10 +259,8 @@ static struct clk *clk_reg_prcmu(const char *name,
        }

        clk = kzalloc(sizeof(struct clk_prcmu), GFP_KERNEL);
-       if (!clk) {
-               pr_err("clk_prcmu: %s could not allocate clk\n", __func__);
+       if (!clk)
                return ERR_PTR(-ENOMEM);
-       }

        clk->cg_sel = cg_sel;
        clk->is_prepared = 1;

diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c
index 8a4e93ce1e42..e0a834c08a04 100644
--- a/drivers/clk/ux500/clk-sysctrl.c
+++ b/drivers/clk/ux500/clk-sysctrl.c

@@ -140,10 +140,8 @@ static struct clk *clk_reg_sysctrl(struct device *dev,
        }

        clk = devm_kzalloc(dev, sizeof(struct clk_sysctrl), GFP_KERNEL);
-       if (!clk) {
-               dev_err(dev, "clk_sysctrl: could not allocate clk\n");
+       if (!clk)
                return ERR_PTR(-ENOMEM);
-       }

        /* set main clock registers */
        clk->reg_sel[0] = reg_sel[0];
--

2.14.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] clk/ux500: Improve a size determination in three functions

From: Ulf Hansson <hidden>
Date: 2017-09-28 16:04:23

On 27 September 2017 at 20:47, SF Markus Elfring
[off-list ref] wrote:

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:30:53 +0200

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>

Acked-by: Ulf Hansson <redacted>

quoted hunk

---
 drivers/clk/ux500/clk-prcc.c    | 2 +-
 drivers/clk/ux500/clk-prcmu.c   | 2 +-
 drivers/clk/ux500/clk-sysctrl.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/ux500/clk-prcc.c b/drivers/clk/ux500/clk-prcc.c
index 5ca07e6d1f64..7cfb59c9136d 100644
--- a/drivers/clk/ux500/clk-prcc.c
+++ b/drivers/clk/ux500/clk-prcc.c

@@ -107,7 +107,7 @@ static struct clk *clk_reg_prcc(const char *name,
                return ERR_PTR(-EINVAL);
        }

-       clk = kzalloc(sizeof(struct clk_prcc), GFP_KERNEL);
+       clk = kzalloc(sizeof(*clk), GFP_KERNEL);
        if (!clk)
                return ERR_PTR(-ENOMEM);

diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index c137934f23ab..9d1f2d4550ad 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c

@@ -258,7 +258,7 @@ static struct clk *clk_reg_prcmu(const char *name,
                return ERR_PTR(-EINVAL);
        }

-       clk = kzalloc(sizeof(struct clk_prcmu), GFP_KERNEL);
+       clk = kzalloc(sizeof(*clk), GFP_KERNEL);
        if (!clk)
                return ERR_PTR(-ENOMEM);

diff --git a/drivers/clk/ux500/clk-sysctrl.c b/drivers/clk/ux500/clk-sysctrl.c
index e0a834c08a04..7c0403b733ae 100644
--- a/drivers/clk/ux500/clk-sysctrl.c
+++ b/drivers/clk/ux500/clk-sysctrl.c

@@ -139,7 +139,7 @@ static struct clk *clk_reg_sysctrl(struct device *dev,
                return ERR_PTR(-EINVAL);
        }

-       clk = devm_kzalloc(dev, sizeof(struct clk_sysctrl), GFP_KERNEL);
+       clk = devm_kzalloc(dev, sizeof(*clk), GFP_KERNEL);
        if (!clk)
                return ERR_PTR(-ENOMEM);

--

2.14.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 2/2] clk/ux500: Improve a size determination in three functions

From: Stephen Boyd <hidden>
Date: 2017-11-14 01:59:33

On 09/27, SF Markus Elfring wrote:

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:30:53 +0200

Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH 1/2] clk/ux500: Delete an error message for a failed memory allocation in three functions

From: Stephen Boyd <hidden>
Date: 2017-11-14 02:00:29

On 09/27, SF Markus Elfring wrote:

From: Markus Elfring <redacted>
Date: Wed, 27 Sep 2017 20:23:58 +0200

Omit extra messages for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help