@@ -326,6 +326,7 @@ swir Sierra Wireless syna Synaptics Inc. synology Synology, Inc. tbs TBS Technologies+tbs-biometrics Touchless Biometric Systems AG tcg Trusted Computing Group tcl Toby Churchill Ltd. technexion TechNexion
From: Maxime Ripard <hidden> Date: 2017-08-25 09:26:16
The A83T has an UART1 controller, with the RTS and CTS pins routed so it
can be used for devices with hardware flow control, like a bluetooth chip.
Signed-off-by: Maxime Ripard <redacted>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
On Fri, Aug 25, 2017 at 5:26 PM, Maxime Ripard
[off-list ref] wrote:
quoted hunk
The A83T has an UART1 controller, with the RTS and CTS pins routed so it
can be used for devices with hardware flow control, like a bluetooth chip.
Signed-off-by: Maxime Ripard <redacted>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Since uart1 is only available on the PG pin group, this name
doesn't provide much info. Instead lets name it uart1_rxtx_pins.
This matches the naming scheme for the rts/cts pingroup.
Otherwise,
Acked-by: Chen-Yu Tsai <redacted>
From: Maxime Ripard <hidden> Date: 2017-09-01 13:16:24
On Thu, Aug 31, 2017 at 02:48:20PM +0800, Chen-Yu Tsai wrote:
On Fri, Aug 25, 2017 at 5:26 PM, Maxime Ripard
[off-list ref] wrote:
quoted
The A83T has an UART1 controller, with the RTS and CTS pins routed so it
can be used for devices with hardware flow control, like a bluetooth chip.
Signed-off-by: Maxime Ripard <redacted>
---
arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Since uart1 is only available on the PG pin group, this name
doesn't provide much info. Instead lets name it uart1_rxtx_pins.
This matches the naming scheme for the rts/cts pingroup.
From: Maxime Ripard <hidden> Date: 2017-08-25 09:26:17
The TBS A711 is a tablet with an A83T, a modem, wifi/BT chip, an eMMC and a
1024x600 LVDS display.
Signed-off-by: Maxime Ripard <redacted>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 195 ++++++++++++++++++++++++++++++
2 files changed, 196 insertions(+)
create mode 100644 arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -0,0 +1,195 @@+/*+*Copyright(C)2017TouchlessBiometricSystemsAG+*TomasNovotny<tomas@novotny.cz>+*+*Thisfileisdual-licensed:youcanuseiteitherundertheterms+*oftheGPLortheX11license,atyouroption.Notethatthisdual+*licensingonlyappliestothisfile,andnotthisprojectasa+*whole.+*+*a)Thisfileisfreesoftware;youcanredistributeitand/or+*modifyitunderthetermsoftheGNUGeneralPublicLicenseas+*publishedbytheFreeSoftwareFoundation;eitherversion2ofthe+*License,or(atyouroption)anylaterversion.+*+*Thisfileisdistributedinthehopethatitwillbeuseful,+*butWITHOUTANYWARRANTY;withouteventheimpliedwarrantyof+*MERCHANTABILITYorFITNESSFORAPARTICULARPURPOSE.Seethe+*GNUGeneralPublicLicenseformoredetails.+*+*Or,alternatively,+*+*b)Permissionisherebygranted,freeofcharge,toanyperson+*obtainingacopyofthissoftwareandassociateddocumentation+*files(the"Software"),todealintheSoftwarewithout+*restriction,includingwithoutlimitationtherightstouse,+*copy,modify,merge,publish,distribute,sublicense,and/or+*sellcopiesoftheSoftware,andtopermitpersonstowhomthe+*Softwareisfurnishedtodoso,subjecttothefollowing+*conditions:+*+*Theabovecopyrightnoticeandthispermissionnoticeshallbe+*includedinallcopiesorsubstantialportionsoftheSoftware.+*+*THESOFTWAREISPROVIDED"AS IS",WITHOUTWARRANTYOFANYKIND,+*EXPRESSORIMPLIED,INCLUDINGBUTNOTLIMITEDTOTHEWARRANTIES+*OFMERCHANTABILITY,FITNESSFORAPARTICULARPURPOSEAND+*NONINFRINGEMENT.INNOEVENTSHALLTHEAUTHORSORCOPYRIGHT+*HOLDERSBELIABLEFORANYCLAIM,DAMAGESOROTHERLIABILITY,+*WHETHERINANACTIONOFCONTRACT,TORTOROTHERWISE,ARISING+*FROM,OUTOFORINCONNECTIONWITHTHESOFTWAREORTHEUSEOR+*OTHERDEALINGSINTHESOFTWARE.+*/++/dts-v1/;+#include"sun8i-a83t.dtsi"+#include"sunxi-common-regulators.dtsi"++/{+model="TBS A711 Tablet";+compatible="tbs-biometrics,a711","allwinner,sun8i-a83t";++aliases{+serial0=&uart0;+serial1=&uart1;+};++chosen{+stdout-path="serial0:115200n8";+};++reg_vbat:reg-vbat{+compatible="regulator-fixed";+regulator-name="vbat";+regulator-min-microvolt=<3700000>;+regulator-max-microvolt=<3700000>;+};++reg_vmain:reg-vmain{+compatible="regulator-fixed";+regulator-name="vmain";+regulator-min-microvolt=<5000000>;+regulator-max-microvolt=<5000000>;+gpio=<&r_pio09GPIO_ACTIVE_HIGH>;+enable-active-high;+vin-supply=<®_vbat>;+};++wifi_pwrseq:wifi_pwrseq{+compatible="mmc-pwrseq-simple";+reset-gpios=<&r_pio02GPIO_ACTIVE_LOW>;/* PL2 WL-PMU-EN */++/*+*ThisisactuallyBluetooth'sclock,butwehaveto+*hookitupsomewheere+*/+clocks=<&ac100_rtc1>;+clock-names="ext_clock";+};+};++/*+*AnUSB-2hubisconnectedhere,whichalsomeanswedon'tneedto+*enabletheOHCIcontroller.+*/+&ehci0{+status="okay";+};++/*+*There'samodemconnectedherethatneedstobeinitialisedbefore+*beingabletobeenumerated.+*/+&ehci1{+status="okay";+};++&mmc0{+vmmc-supply=<®_vcc3v3>;+pinctrl-names="default";+pinctrl-0=<&mmc0_pins>;+cd-gpios=<&pio56GPIO_ACTIVE_LOW>;+status="okay";+};++&mmc1{+mmc-pwrseq=<&wifi_pwrseq>;+bus-width=<4>;+pinctrl-names="default";+pinctrl-0=<&mmc1_pins>;+vmmc-supply=<®_vcc3v3>;+non-removable;+wakeup-source;+status="okay";++brcmf:wifiat1{+reg=<1>;+compatible="brcm,bcm4329-fmac";+interrupt-parent=<&r_pio>;+interrupts=<03IRQ_TYPE_LEVEL_LOW>;/* PL3 WL_WAKE_UP */+interrupt-names="host-wake";+};+};++&mmc2{+pinctrl-0=<&mmc2_8bit_emmc_pins>;+pinctrl-names="default";+vmmc-supply=<®_vcc3v3>;+bus-width=<8>;+non-removable;+cap-mmc-hw-reset;+status="okay";+};++&r_rsb{+status="okay";++axp813:pmicat3a3{+compatible="x-powers,axp813";+reg=<0x3a3>;+interrupt-parent=<&r_intc>;+interrupts=<0IRQ_TYPE_LEVEL_LOW>;+};++ac100:codecate89{+compatible="x-powers,ac100";+reg=<0xe89>;++ac100_codec:codec{+compatible="x-powers,ac100-codec";+interrupt-parent=<&r_pio>;+interrupts=<012IRQ_TYPE_LEVEL_LOW>;/* PL12 */+#clock-cells=<0>;+clock-output-names="4M_adda";+};++ac100_rtc:rtc{+compatible="x-powers,ac100-rtc";+interrupt-parent=<&r_intc>;+interrupts=<0IRQ_TYPE_LEVEL_LOW>;+clocks=<&ac100_codec>;+#clock-cells=<1>;+clock-output-names="cko1_rtc",+"cko2_rtc",+"cko3_rtc";+};+};++};++&uart0{+pinctrl-names="default";+pinctrl-0=<&uart0_pb_pins>;+status="okay";+};++/* There's the BT part of the AP6210 connected to that UART */+&uart1{+pinctrl-names="default";+pinctrl-0=<&uart1_pg_pins&uart1_rtscts_pins>;+status="okay";+};++&usbphy{+status="okay";+};
On Fri, Aug 25, 2017 at 5:26 PM, Maxime Ripard
[off-list ref] wrote:
quoted hunk
The TBS A711 is a tablet with an A83T, a modem, wifi/BT chip, an eMMC and a
1024x600 LVDS display.
Signed-off-by: Maxime Ripard <redacted>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 195 ++++++++++++++++++++++++++++++
2 files changed, 196 insertions(+)
create mode 100644 arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
emmc has separate vddq lines. vqmmc-supply should be provided even though it
may be the same as vmmc-supply. The two refer to different things at the board
level.
emmc has separate vddq lines. vqmmc-supply should be provided even though it
may be the same as vmmc-supply. The two refer to different things at the board
level.
My understanding was that vqmmc wasn't needed if it was the same
regulator than vmmc.
quoted
+/* There's the BT part of the AP6210 connected to that UART */
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart1_pg_pins &uart1_rtscts_pins>;
Splitting it as separate phandles ( <&...> ) would make it more readable.
Also the rx/tx pingroup name should be changed
emmc has separate vddq lines. vqmmc-supply should be provided even though it
may be the same as vmmc-supply. The two refer to different things at the board
level.
My understanding was that vqmmc wasn't needed if it was the same
regulator than vmmc.
It doesn't say so in the binding, so that's probably only true for Linux.
ChenYu
quoted
quoted
+/* There's the BT part of the AP6210 connected to that UART */
+&uart1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart1_pg_pins &uart1_rtscts_pins>;
Splitting it as separate phandles ( <&...> ) would make it more readable.
Also the rx/tx pingroup name should be changed
Ack.
quoted
quoted
+ status = "okay";
+};
+
+&usbphy {
No VBUS?
Argh, I forgot them. I'll add them, obviously.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
emmc has separate vddq lines. vqmmc-supply should be provided even though it
may be the same as vmmc-supply. The two refer to different things at the board
level.
My understanding was that vqmmc wasn't needed if it was the same
regulator than vmmc.
It doesn't say so in the binding, so that's probably only true for Linux.