Thread (15 messages) 15 messages, 3 authors, 2017-08-28

[PATCH v2 2/3] rtc: Add Realtek RTD1295

From: andrew@lunn.ch (Andrew Lunn)
Date: 2017-08-27 13:38:26
Also in: linux-rtc, lkml

quoted
quoted
+static inline int rtd119x_rtc_year_days(int year)
+{
+	return rtc_year_days(1, 12, year);
I'm not sure it is worth wrapping rtc_year_days
[snip]

Well, I found your rtc_year_days rather confusing and had to play with
the arguments until I got it working as expected, so I wanted an inline
function (or macro) as abstraction from my three callers.
I agree with that. I was wondering why 1st December was being used. I
would say this API does not do too well on Rusty's API Design
Manifesto.

It does at least get the day/month/year in the right order ;-)

	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help