On Sun, Aug 27, 2017 at 04:30:08AM +0200, Andreas F?rber wrote:

Am 27.08.2017 um 04:05 schrieb Andrew Lunn:

quoted

n Sun, Aug 27, 2017 at 02:33:27AM +0200, Andreas F?rber wrote:

quoted

+struct rtd119x_rtc {
+	void __iomem *base;
+	struct clk *clk;
+	struct rtc_device *rtcdev;
+	unsigned base_year;
+	spinlock_t lock;

Where is this lock initialised? I would expect a call to
spin_lock_init() somewhere.

Hm, the spinlock in my irq mux series doesn't have that call either; my
reset driver did have it. The zero initialization appears to work OK,
but you're probably right that it should be there.

Hi Andreas

I suspect you will have problems if you enable spin lock debug code,
like CONFIG_DEBUG_SPINLOCK.

     Andrew