# \[PATCH\] arm64: avoid overflow in VA\_START and PAGE\_OFFSET

- From: Nick Desaulniers \<ndesaulniers@google.com\>
- Date: 2017-08-03 17:53:14 
- List: linux-arm-kernel
- Page: https://ratatoskr.run/linux-arm-kernel/2017/08/5058892
- Thread: https://ratatoskr.run/linux-arm-kernel/2017/08/5058100/t.md

```text
> Would
>
> #define VA_START (UL(0xffffffffffffffff) - (1 << VA_BITS) + 1)
>
> also work?

I think you'd have to wrap the 1 in a UL(), ex:

#define VA_START (UL(0xffffffffffffffff) - (UL(1) << VA_BITS) + 1)

Otherwise IIUC a integral literal (`1`) is treated as an int, which on
arm64 is LP64 making it 32b, where most configs set VA_BITS
to larger than 32b.  Shifting by more than the width is undefined
behavior. And without it, I get compile errors.

I'll send v2 with your suggestion, thanks.
-- 
Thanks,
~Nick Desaulniers
```
