DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH] tee: optee: interruptible RPC sleep

From: Jens Wiklander <hidden>
Date: 2017-07-17 10:10:32
Also in: lkml
Subsystem: op-tee driver, tee subsystem, the rest · Maintainers: Jens Wiklander, Linus Torvalds

From: tiger-yu99 <redacted>

Prior to this patch RPC sleep was uninterruptible since msleep() is
uninterruptible. Change to use msleep_interruptible() instead.

Signed-off-by: Tiger Yu <redacted>
Reviewed-by: Joakim Bech <redacted>
Signed-off-by: Jerome Forissier <redacted>
Signed-off-by: Jens Wiklander <redacted>
---
 drivers/tee/optee/rpc.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
index 8814eca06021..9488ed1541bc 100644
--- a/drivers/tee/optee/rpc.c
+++ b/drivers/tee/optee/rpc.c
@@ -140,11 +140,8 @@ static void handle_rpc_func_cmd_wait(struct optee_msg_arg *arg)
 
 	msec_to_wait = arg->params[0].u.value.a;
 
-	/* set task's state to interruptible sleep */
-	set_current_state(TASK_INTERRUPTIBLE);
-
-	/* take a nap */
-	msleep(msec_to_wait);
+	/* Go to interruptible sleep */
+	msleep_interruptible(msec_to_wait);
 
 	arg->ret = TEEC_SUCCESS;
 	return;
-- 
2.7.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help