[PATCH] ARM: debug-ll: Add support for r8a7743

STALE3374d

6 messages, 3 authors, 2017-07-05 · open the first message on its own page

[PATCH] ARM: debug-ll: Add support for r8a7743

From: Chris Paterson <hidden>
Date: 2017-06-08 07:48:37

Enable low-level debugging support for RZ/G1M (r8a7743). RZ/G1M uses
SCIF0 for the debug console, like most of the R-Car Gen2 SoCs.

Signed-off-by: Chris Paterson <redacted>
---
 arch/arm/Kconfig.debug | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index ba2cb63..fd5164c 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug

@@ -895,12 +895,13 @@ choice
 		  via SCIF2 on Renesas R-Car H1 (R8A7779).
 
 	config DEBUG_RCAR_GEN2_SCIF0
-		bool "Kernel low-level debugging messages via SCIF0 on R8A7790/R8A7791/R8A7792/R8A7793"
-		depends on ARCH_R8A7790 || ARCH_R8A7791 || ARCH_R8A7792 || ARCH_R8A7793
+		bool "Kernel low-level debugging messages via SCIF0 on R8A7743/R8A7790/R8A7791/R8A7792/R8A7793"
+		depends on ARCH_R8A7743 || ARCH_R8A7790 || ARCH_R8A7791 || \
+			ARCH_R8A7792 || ARCH_R8A7793
 		help
 		  Say Y here if you want kernel low-level debugging support
-		  via SCIF0 on Renesas R-Car H2 (R8A7790), M2-W (R8A7791), V2H
-		  (R8A7792), or M2-N (R8A7793).
+		  via SCIF0 on Renesas RZ/G1M (R8A7743), R-Car H2 (R8A7790),
+		  M2-W (R8A7791), V2H (R8A7792), or M2-N (R8A7793).
 
 	config DEBUG_RCAR_GEN2_SCIF2
 		bool "Kernel low-level debugging messages via SCIF2 on R8A7794"

-- 
1.9.1

[PATCH] ARM: debug-ll: Add support for r8a7743

From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2017-06-08 08:26:46

Hi Chris,

On Thu, Jun 8, 2017 at 9:48 AM, Chris Paterson
[off-list ref] wrote:

Enable low-level debugging support for RZ/G1M (r8a7743). RZ/G1M uses
SCIF0 for the debug console, like most of the R-Car Gen2 SoCs.

Thanks for your patch!

While the recommended debug method these days is "earlycon", DEBUG_LL is
indeed still useful to debug issues before earlycon is initialized.
Let's hope you will never encounter such issues on arm64, which doesn't
have DEBUG_LL per policy decision...

Signed-off-by: Chris Paterson <redacted>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

quoted hunk

--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug

@@ -895,12 +895,13 @@ choice
                  via SCIF2 on Renesas R-Car H1 (R8A7779).

        config DEBUG_RCAR_GEN2_SCIF0
-               bool "Kernel low-level debugging messages via SCIF0 on R8A7790/R8A7791/R8A7792/R8A7793"
-               depends on ARCH_R8A7790 || ARCH_R8A7791 || ARCH_R8A7792 || ARCH_R8A7793
+               bool "Kernel low-level debugging messages via SCIF0 on R8A7743/R8A7790/R8A7791/R8A7792/R8A7793"

This line is becoming a bit long, and it'll only become worse in the future.
What about "Kernel low-level debugging messages via SCIF0 on R-Car Gen2"?
The full list of SoCs is still available in the extended help text.

+               depends on ARCH_R8A7743 || ARCH_R8A7790 || ARCH_R8A7791 || \
+                       ARCH_R8A7792 || ARCH_R8A7793
                help
                  Say Y here if you want kernel low-level debugging support
-                 via SCIF0 on Renesas R-Car H2 (R8A7790), M2-W (R8A7791), V2H
-                 (R8A7792), or M2-N (R8A7793).
+                 via SCIF0 on Renesas RZ/G1M (R8A7743), R-Car H2 (R8A7790),
+                 M2-W (R8A7791), V2H (R8A7792), or M2-N (R8A7793).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] ARM: debug-ll: Add support for r8a7743

From: Chris Paterson <hidden>
Date: 2017-06-08 08:50:01

Hello Geert,

From: geert.uytterhoeven at gmail.com
[mailto:geert.uytterhoeven at gmail.com] On Behalf Of Geert Uytterhoeven
Sent: 08 June 2017 09:27

Hi Chris,

On Thu, Jun 8, 2017 at 9:48 AM, Chris Paterson
[off-list ref] wrote:

quoted

Enable low-level debugging support for RZ/G1M (r8a7743). RZ/G1M uses
SCIF0 for the debug console, like most of the R-Car Gen2 SoCs.

Thanks for your patch!

Thank you for your review!

While the recommended debug method these days is "earlycon", DEBUG_LL
is indeed still useful to debug issues before earlycon is initialized.
Let's hope you will never encounter such issues on arm64, which doesn't
have DEBUG_LL per policy decision...

Thank you for the information. It's hard to keep up with these decisions!

quoted

Signed-off-by: Chris Paterson <redacted>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

quoted

--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug

@@ -895,12 +895,13 @@ choice
                  via SCIF2 on Renesas R-Car H1 (R8A7779).

        config DEBUG_RCAR_GEN2_SCIF0
-               bool "Kernel low-level debugging messages via SCIF0 on

R8A7790/R8A7791/R8A7792/R8A7793"

quoted

-               depends on ARCH_R8A7790 || ARCH_R8A7791 || ARCH_R8A7792

|| ARCH_R8A7793

quoted

+               bool "Kernel low-level debugging messages via SCIF0 on

R8A7743/R8A7790/R8A7791/R8A7792/R8A7793"

This line is becoming a bit long, and it'll only become worse in the future.
What about "Kernel low-level debugging messages via SCIF0 on R-Car Gen2"?

What about "Kernel low-level debugging messages via SCIF0 on R-Car Gen2 and RZ/G1"?

I'd like to try and keep some sort of split between the two product lines if possible.

Kind regards, Chris

The full list of SoCs is still available in the extended help text.

quoted

+               depends on ARCH_R8A7743 || ARCH_R8A7790 || ARCH_R8A7791

|| \

quoted

+                       ARCH_R8A7792 || ARCH_R8A7793
                help
                  Say Y here if you want kernel low-level debugging support
-                 via SCIF0 on Renesas R-Car H2 (R8A7790), M2-W (R8A7791), V2H
-                 (R8A7792), or M2-N (R8A7793).
+                 via SCIF0 on Renesas RZ/G1M (R8A7743), R-Car H2 (R8A7790),
+                 M2-W (R8A7791), V2H (R8A7792), or M2-N (R8A7793).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-
m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] ARM: debug-ll: Add support for r8a7743

From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2017-06-08 09:26:39

Hi Chris,

On Thu, Jun 8, 2017 at 10:50 AM, Chris Paterson
[off-list ref] wrote:

quoted

--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug

@@ -895,12 +895,13 @@ choice
                  via SCIF2 on Renesas R-Car H1 (R8A7779).

        config DEBUG_RCAR_GEN2_SCIF0
-               bool "Kernel low-level debugging messages via SCIF0 on

R8A7790/R8A7791/R8A7792/R8A7793"

quoted

-               depends on ARCH_R8A7790 || ARCH_R8A7791 || ARCH_R8A7792

|| ARCH_R8A7793

quoted

+               bool "Kernel low-level debugging messages via SCIF0 on

R8A7743/R8A7790/R8A7791/R8A7792/R8A7793"

This line is becoming a bit long, and it'll only become worse in the future.
What about "Kernel low-level debugging messages via SCIF0 on R-Car Gen2"?

What about "Kernel low-level debugging messages via SCIF0 on R-Car Gen2 and RZ/G1"?

Oops, of course. That's what I intended to type ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v2] ARM: debug-ll: Add support for r8a7743

From: Chris Paterson <hidden>
Date: 2017-06-08 10:08:14

Enable low-level debugging support for RZ/G1M (r8a7743). RZ/G1M uses
SCIF0 for the debug console, like most of the R-Car Gen2 SoCs.

Signed-off-by: Chris Paterson <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Added Geert reviewed-by
- Shortened config description

 arch/arm/Kconfig.debug | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index ba2cb63..1b2c4c4 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug

@@ -895,12 +895,13 @@ choice
 		  via SCIF2 on Renesas R-Car H1 (R8A7779).
 
 	config DEBUG_RCAR_GEN2_SCIF0
-		bool "Kernel low-level debugging messages via SCIF0 on R8A7790/R8A7791/R8A7792/R8A7793"
-		depends on ARCH_R8A7790 || ARCH_R8A7791 || ARCH_R8A7792 || ARCH_R8A7793
+		bool "Kernel low-level debugging messages via SCIF0 on R-Car Gen2 and RZ/G1"
+		depends on ARCH_R8A7743 || ARCH_R8A7790 || ARCH_R8A7791 || \
+			ARCH_R8A7792 || ARCH_R8A7793
 		help
 		  Say Y here if you want kernel low-level debugging support
-		  via SCIF0 on Renesas R-Car H2 (R8A7790), M2-W (R8A7791), V2H
-		  (R8A7792), or M2-N (R8A7793).
+		  via SCIF0 on Renesas RZ/G1M (R8A7743), R-Car H2 (R8A7790),
+		  M2-W (R8A7791), V2H (R8A7792), or M2-N (R8A7793).
 
 	config DEBUG_RCAR_GEN2_SCIF2
 		bool "Kernel low-level debugging messages via SCIF2 on R8A7794"

-- 
1.9.1

[PATCH v2] ARM: debug-ll: Add support for r8a7743

From: horms@verge.net.au (Simon Horman)
Date: 2017-07-05 10:24:32

On Thu, Jun 08, 2017 at 11:08:14AM +0100, Chris Paterson wrote:

Enable low-level debugging support for RZ/G1M (r8a7743). RZ/G1M uses
SCIF0 for the debug console, like most of the R-Car Gen2 SoCs.

Signed-off-by: Chris Paterson <redacted>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v4.14.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help