omap_uart_phys, omap_uart_virt and omap_uart_lsr reside in .data section
and it's right implementation. But because of this, we cannot enable
CONFIG_DEBUG_UNCOMPRESS. LL_DEBUG and DEBUG_UNCOMPRESS are very useful tools
for debugging early boot stage when something goes wrong if you don't have
any hardware based debugging tools like a JTAG debugger.
This patch is to put the variables into .text section instead only when the
DEBUG_LL_INCLUDE file is included in the kernel decompressor, which is only
when ZIMAGE is defined.
This patch does not change anything when DEBUG_LL_INCLUDE is included in
the other kernel parts like arch/arm/kernel/*
Signed-off-by: Hoeun Ryu <redacted>
---
* to mail to relevant recipients, no respond yet from them
- TO=Tony Lindgren [off-list ref]
- CC=linux-omap at vger.kernel.org
* indentical to previous patch
arch/arm/include/debug/omap2plus.S | 11 +++++++++++
1 file changed, 11 insertions(+)
With a patch 9a5151e1d1ba4df41bc4b8e8c0f17163247645ac, "arm:omap2+: put
omap_uart_phys/virt/lsr in .text section when ZIMAGE is true", the
dependence on DEBUG_OMAP2PLUS_UART for DEBUG_UNCOMPRESS can be dropped,
because all code of omap2+'s DEBUG_LL_INCLUDE file is in .text section when
it's included in the decompressor.
Signed-off-by: Hoeun Ryu <redacted>
---
* mail to relevant recipients, no response yet from them.
- add TO=Tony Lindgren [off-list ref]
- add CC=linux-omap at vger.kernel.org
* indentical to previous patch
arch/arm/Kconfig.debug | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
So I converted all these to use the 8250 debug_ll yesterday
which should solve the DEBUG_UNCOMPRESS issue for you and
allows us to remove this file. Will post the series shortly
for testing with you in Cc after I've done a bit more testing
here.
Regards,
Tony
?
?#define UART_OFFSET(addr) ((addr) & 0x00ffffff)
?
+/*
+ * Definition of ZIMAGE is in arch/arm/boot/compressed/Makefile.
+ * Place the following block in .text section only when this file
is
+ * included by arch/arm/boot/compressed/* to make it possible to
+ * enable CONFIG_DEBUG_UNCOMPRESS and DEBUG in
arch/arm/boot/compressed/head.S
+ * on OMAP2+ SoCs.
+ */
+#ifndef ZIMAGE
? .pushsection .data
+#endif
?omap_uart_phys: .word 0
?omap_uart_virt: .word 0
?omap_uart_lsr: .word 0
+#ifndef ZIMAGE
? .popsection
+#endif
So I converted all these to use the 8250 debug_ll yesterday
which should solve the DEBUG_UNCOMPRESS issue for you and
allows us to remove this file. Will post the series shortly
for testing with you in Cc after I've done a bit more testing
here.
It sounds good.
patch 01 is dropped though, are you using the second patch ?
"[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for
DEBUG_UNCOMPRESS"
Thank you.
From: Tony Lindgren <tony@atomide.com> Date: 2017-06-14 07:24:05
* Hoeun Ryu [off-list ref] [170613 23:57]:
On Tue, 2017-06-13 at 22:27 -0700, Tony Lindgren wrote:
quoted
So I converted all these to use the 8250 debug_ll yesterday
which should solve the DEBUG_UNCOMPRESS issue for you and
allows us to remove this file. Will post the series shortly
for testing with you in Cc after I've done a bit more testing
here.
It sounds good.
patch 01 is dropped though, are you using the second patch ?
"[PATCH 2/2] arm:omap2+: drop dependence on DEBUG_OMAP2PLUS_UART for
DEBUG_UNCOMPRESS"
I folded it into the patch removing all users of DEBUG_OMAP2PLUS_UART
as that seems to make most sense here.
Regards,
Tony