@@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,}staticintsnd_bcm2835_ctl_put(structsnd_kcontrol*kcontrol,-structsnd_ctl_elem_value*ucontrol)+structsnd_ctl_elem_value*ucontrol){structbcm2835_chip*chip=snd_kcontrol_chip(kcontrol);intchanged=0;
This patch is corrupted and can not be applied :(
Why is this corrupted ?
Try applying it with `git am`. There should be space characters at the
start of these lines but your email client deleted them:
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
Read Documentation/process/email-clients.rst
regards,
dan carpenter
@@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,}staticintsnd_bcm2835_ctl_put(structsnd_kcontrol*kcontrol,-structsnd_ctl_elem_value*ucontrol)+structsnd_ctl_elem_value*ucontrol){structbcm2835_chip*chip=snd_kcontrol_chip(kcontrol);intchanged=0;
This patch is corrupted and can not be applied :(
Why is this corrupted ?
Try applying it with `git am`. There should be space characters at the
start of these lines but your email client deleted them:
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
Read Documentation/process/email-clients.rst
regards,
dan carpenter
Hello,
I tried applying it with ' git am ' and it was giving me this error:
fatal: corrupt patch at line XX
I think this was produced because of running ./scripts/cleanfile on the patch .
I was using this to fix trailing whitespaces . So, I used a different
method to remove them and didn't get that error.
But now when I run 'git am' I get a different error:
error: patch failed:
drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c:105
Why am I getting this error ?
Regards,
Srishti
@@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,}staticintsnd_bcm2835_ctl_put(structsnd_kcontrol*kcontrol,-structsnd_ctl_elem_value*ucontrol)+structsnd_ctl_elem_value*ucontrol){structbcm2835_chip*chip=snd_kcontrol_chip(kcontrol);intchanged=0;
This patch is corrupted and can not be applied :(
Why is this corrupted ?
Try applying it with `git am`. There should be space characters at the
start of these lines but your email client deleted them:
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
Read Documentation/process/email-clients.rst
regards,
dan carpenter
Hello,
I tried applying it with ' git am ' and it was giving me this error:
fatal: corrupt patch at line XX
Exactly.
I think this was produced because of running ./scripts/cleanfile on the patch .
Why would you do that? By doing that you corrupted the patch file :(
Just use the proper output of 'git format-patch' and all will be fine.
thanks,
greg k-h
@@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,}staticintsnd_bcm2835_ctl_put(structsnd_kcontrol*kcontrol,-structsnd_ctl_elem_value*ucontrol)+structsnd_ctl_elem_value*ucontrol){structbcm2835_chip*chip=snd_kcontrol_chip(kcontrol);intchanged=0;
This patch is corrupted and can not be applied :(
Why is this corrupted ?
Try applying it with `git am`. There should be space characters at the
start of these lines but your email client deleted them:
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
Read Documentation/process/email-clients.rst
regards,
dan carpenter
Hello,
I tried applying it with ' git am ' and it was giving me this error:
fatal: corrupt patch at line XX
Exactly.
quoted
I think this was produced because of running ./scripts/cleanfile on the patch .
Why would you do that? By doing that you corrupted the patch file :(
After I run ./scritps/checkpatch.pl on the patch produced by git
format-patch it has trailing whitespaces . So I was using
./scripts/cleanfile to fix that , I am not doing that anymore and am
also not getting the corrupt patch error .
Just use the proper output of 'git format-patch' and all will be fine.
I have done this and am still getting these errors:
error: patch failed:
drivers/staging/vc04_services/bcm2835-audio/bcm2835- ctl.c:105
error: drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c:
patch does not apply
Why is it not applying ?
Regards,
Srishti
@@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,}staticintsnd_bcm2835_ctl_put(structsnd_kcontrol*kcontrol,-structsnd_ctl_elem_value*ucontrol)+structsnd_ctl_elem_value*ucontrol){structbcm2835_chip*chip=snd_kcontrol_chip(kcontrol);intchanged=0;
This patch is corrupted and can not be applied :(
Why is this corrupted ?
Try applying it with `git am`. There should be space characters at the
start of these lines but your email client deleted them:
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
Read Documentation/process/email-clients.rst
regards,
dan carpenter
Hello,
I tried applying it with ' git am ' and it was giving me this error:
fatal: corrupt patch at line XX
Exactly.
quoted
I think this was produced because of running ./scripts/cleanfile on the patch .
Why would you do that? By doing that you corrupted the patch file :(
After I run ./scritps/checkpatch.pl on the patch produced by git
format-patch it has trailing whitespaces . So I was using
./scripts/cleanfile to fix that , I am not doing that anymore and am
also not getting the corrupt patch error .
That means your code had trailing whitespaces, always fix that and NEVER
hand-edit or modify a patch unless you really know what you are doing.
quoted
Just use the proper output of 'git format-patch' and all will be fine.
I have done this and am still getting these errors:
error: patch failed:
drivers/staging/vc04_services/bcm2835-audio/bcm2835- ctl.c:105
error: drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c:
patch does not apply
Why is it not applying ?
That is up to you to figure out, we have no idea as to exactly what you
are doing :)
good luck!
greg k-h
@@ -105,7 +105,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,}staticintsnd_bcm2835_ctl_put(structsnd_kcontrol*kcontrol,-structsnd_ctl_elem_value*ucontrol)+structsnd_ctl_elem_value*ucontrol){structbcm2835_chip*chip=snd_kcontrol_chip(kcontrol);intchanged=0;
This patch is corrupted and can not be applied :(
Why is this corrupted ?
Try applying it with `git am`. There should be space characters at the
start of these lines but your email client deleted them:
struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
int changed = 0;
Read Documentation/process/email-clients.rst
regards,
dan carpenter
Hello,
I tried applying it with ' git am ' and it was giving me this error:
fatal: corrupt patch at line XX
Exactly.
quoted
I think this was produced because of running ./scripts/cleanfile on the patch .
Why would you do that? By doing that you corrupted the patch file :(
After I run ./scritps/checkpatch.pl on the patch produced by git
format-patch it has trailing whitespaces . So I was using
./scripts/cleanfile to fix that , I am not doing that anymore and am
also not getting the corrupt patch error .
That means your code had trailing whitespaces, always fix that and NEVER
hand-edit or modify a patch unless you really know what you are doing.
quoted
quoted
Just use the proper output of 'git format-patch' and all will be fine.
I have done this and am still getting these errors:
error: patch failed:
drivers/staging/vc04_services/bcm2835-audio/bcm2835- ctl.c:105
error: drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c:
patch does not apply
Why is it not applying ?
That is up to you to figure out, we have no idea as to exactly what you
are doing :)
I guess , I was applying the patch to the same repository I made the
change in :P , I am not getting any errors now .