[PATCH] pinctrl: sunxi: constify irq_domain_ops

Subsystems: arm/allwinner sunxi soc support, pin control subsystem, the rest

STALE3386d

3 messages, 3 authors, 2017-06-09 · open the first message on its own page

[PATCH] pinctrl: sunxi: constify irq_domain_ops

From: Tobias Klauser <tklauser@distanz.ch>
Date: 2017-06-02 11:30:06

struct irq_domain_ops is not modified, so it can be made const.

Suggested-by: Marc Zyngier <redacted>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 58774acfc814..0dfd7fa66c48 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -979,7 +979,7 @@ static int sunxi_pinctrl_irq_of_xlate(struct irq_domain *d,
 	return 0;
 }
 
-static struct irq_domain_ops sunxi_pinctrl_irq_domain_ops = {
+static const struct irq_domain_ops sunxi_pinctrl_irq_domain_ops = {
 	.xlate		= sunxi_pinctrl_irq_of_xlate,
 };
 
-- 
2.13.0

Re: [PATCH] pinctrl: sunxi: constify irq_domain_ops

From: Maxime Ripard <hidden>
Date: 2017-06-02 12:08:21

On Fri, Jun 02, 2017 at 01:29:58PM +0200, Tobias Klauser wrote:
struct irq_domain_ops is not modified, so it can be made const.

Suggested-by: Marc Zyngier <redacted>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Maxime Ripard <redacted>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170602/34c22eb3/attachment.sig>

Re: [PATCH] pinctrl: sunxi: constify irq_domain_ops

From: Linus Walleij <hidden>
Date: 2017-06-09 08:59:39

On Fri, Jun 2, 2017 at 1:29 PM, Tobias Klauser [off-list ref] wrote:
struct irq_domain_ops is not modified, so it can be made const.

Suggested-by: Marc Zyngier <redacted>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Patch applied with Maxime's ACK.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help