[PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

Subsystems: arm/rockchip soc support, nvmem framework, open firmware and flattened device tree bindings, the rest

STALE3405d

4 messages, 4 authors, 2017-06-15 · open the first message on its own page

[PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

From: Finley Xiao <hidden>
Date: 2017-05-12 02:44:36 

This adds the necessary data for handling eFuse on the rk322x.

Signed-off-by: Finley Xiao <redacted>
---
 Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
 drivers/nvmem/rockchip-efuse.c                             | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
index 94aeeea..194926f 100644
--- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
+++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible: Should be one of the following.
   - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
   - "rockchip,rk3188-efuse" - for RK3188 SoCs.
+  - "rockchip,rk322x-efuse" - for RK322x SoCs.
   - "rockchip,rk3288-efuse" - for RK3288 SoCs.
   - "rockchip,rk3399-efuse" - for RK3399 SoCs.
 - reg: Should contain the registers location and exact eFuse size
diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
index 423907b..a0d4ede 100644
--- a/drivers/nvmem/rockchip-efuse.c
+++ b/drivers/nvmem/rockchip-efuse.c
@@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
 		.data = (void *)&rockchip_rk3288_efuse_read,
 	},
 	{
+		.compatible = "rockchip,rk322x-efuse",
+		.data = (void *)&rockchip_rk3288_efuse_read,
+	},
+	{
 		.compatible = "rockchip,rk3288-efuse",
 		.data = (void *)&rockchip_rk3288_efuse_read,
 	},
-- 
2.7.4

Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

From: Rob Herring <robh@kernel.org>
Date: 2017-05-15 20:45:45 

On Fri, May 12, 2017 at 10:44:20AM +0800, Finley Xiao wrote:
This adds the necessary data for handling eFuse on the rk322x.

Signed-off-by: Finley Xiao <redacted>
---
 Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
 drivers/nvmem/rockchip-efuse.c                             | 4 ++++
 2 files changed, 5 insertions(+)
Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

From: Frank Wang <hidden>
Date: 2017-06-05 03:51:16 

Hi Finley,

On 2017/5/12 10:44, Finley Xiao wrote:
quoted hunk
This adds the necessary data for handling eFuse on the rk322x.

Signed-off-by: Finley Xiao <redacted>
---
  Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
  drivers/nvmem/rockchip-efuse.c                             | 4 ++++
  2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
index 94aeeea..194926f 100644
--- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
+++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
@@ -4,6 +4,7 @@ Required properties:
  - compatible: Should be one of the following.
    - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
    - "rockchip,rk3188-efuse" - for RK3188 SoCs.
+  - "rockchip,rk322x-efuse" - for RK322x SoCs.
As the comments from Heiko in other patches, compatibles should not 
contain wildcards, so could you please make this
     "rockchip,rk3228-efuse"
instead?
quoted hunk
    - "rockchip,rk3288-efuse" - for RK3288 SoCs.
    - "rockchip,rk3399-efuse" - for RK3399 SoCs.
  - reg: Should contain the registers location and exact eFuse size
diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
index 423907b..a0d4ede 100644
--- a/drivers/nvmem/rockchip-efuse.c
+++ b/drivers/nvmem/rockchip-efuse.c
@@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
  		.data = (void *)&rockchip_rk3288_efuse_read,
  	},
  	{
+		.compatible = "rockchip,rk322x-efuse",
+		.data = (void *)&rockchip_rk3288_efuse_read,
+	},
The same as above.


BR.
Frank
quoted hunk
+	{
  		.compatible = "rockchip,rk3288-efuse",
  		.data = (void *)&rockchip_rk3288_efuse_read,
  	},

Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

From: Heiko Stuebner <heiko@sntech.de>
Date: 2017-06-15 15:12:29 

Am Freitag, 12. Mai 2017, 10:44:20 CEST schrieb Finley Xiao:
quoted hunk
This adds the necessary data for handling eFuse on the rk322x.

Signed-off-by: Finley Xiao <redacted>
---
 Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
 drivers/nvmem/rockchip-efuse.c                             | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
index 94aeeea..194926f 100644
--- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
+++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible: Should be one of the following.
   - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
   - "rockchip,rk3188-efuse" - for RK3188 SoCs.
+  - "rockchip,rk322x-efuse" - for RK322x SoCs.
should be rockchip,rk3228-efuse.

While rk3228 and rk3229 are pratically the same soc, the compatible still
shouldn't contain placeholders.


Heiko
quoted hunk
   - "rockchip,rk3288-efuse" - for RK3288 SoCs.
   - "rockchip,rk3399-efuse" - for RK3399 SoCs.
 - reg: Should contain the registers location and exact eFuse size
diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
index 423907b..a0d4ede 100644
--- a/drivers/nvmem/rockchip-efuse.c
+++ b/drivers/nvmem/rockchip-efuse.c
@@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
 		.data = (void *)&rockchip_rk3288_efuse_read,
 	},
 	{
+		.compatible = "rockchip,rk322x-efuse",
+		.data = (void *)&rockchip_rk3288_efuse_read,
+	},
+	{
 		.compatible = "rockchip,rk3288-efuse",
 		.data = (void *)&rockchip_rk3288_efuse_read,
 	},
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help