[PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

Subsystems: acpi, the rest

STALE3425d

4 messages, 3 authors, 2017-03-25 · open the first message on its own page

[PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

From: Sinan Kaya <hidden>
Date: 2017-03-23 15:53:49

ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver
to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.

IPMI_SSIF is an alternative BMC communication method. It allows BMC to be
accessed over an I2C bus instead of a standard interface.

Enabling ACPI_IPMI over IPMI_SSIF with this change.

Signed-off-by: Sinan Kaya <redacted>
---
 drivers/acpi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 83e5f7e..8767062 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -256,7 +256,7 @@ config ACPI_PROCESSOR
 
 config ACPI_IPMI
 	tristate "IPMI"
-	depends on IPMI_SI
+	depends on IPMI_SI||IPMI_SSIF
 	default n
 	help
 	  This driver enables the ACPI to access the BMC controller. And it
-- 
1.9.1

Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

From: Timur Tabi <hidden>
Date: 2017-03-23 15:56:15

On 03/23/2017 10:53 AM, Sinan Kaya wrote:
+	depends on IPMI_SI||IPMI_SSIF
Blank spaces around ||.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

From: Corey Minyard <hidden>
Date: 2017-03-25 02:56:48

Oops, yes, this is an issue.

However, it should probably depend on IPMI_HANDLER, not the individual 
interface types.

-corey

On 03/23/2017 10:53 AM, Sinan Kaya wrote:
quoted hunk
ACPI_IPMI driver currently depends on IPMI System Interface (IPMI_SI) driver
to be enabled. IPMI_SI driver only handles KCS, SMIC and BT BMC interfaces.

IPMI_SSIF is an alternative BMC communication method. It allows BMC to be
accessed over an I2C bus instead of a standard interface.

Enabling ACPI_IPMI over IPMI_SSIF with this change.

Signed-off-by: Sinan Kaya <redacted>
---
  drivers/acpi/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 83e5f7e..8767062 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -256,7 +256,7 @@ config ACPI_PROCESSOR
  
  config ACPI_IPMI
  	tristate "IPMI"
-	depends on IPMI_SI
+	depends on IPMI_SI||IPMI_SSIF
  	default n
  	help
  	  This driver enables the ACPI to access the BMC controller. And it

Re: [PATCH] ACPI / IPMI: allow ACPI_IPMI with IPMI_SSIF

From: Sinan Kaya <hidden>
Date: 2017-03-25 14:03:45

On 3/24/2017 10:56 PM, Corey Minyard wrote:
Oops, yes, this is an issue.

However, it should probably depend on IPMI_HANDLER, not the individual interface types.
Thanks for the review. I posted V3 with your recommendation.
-corey

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help