[PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

STALE3480d REVIEWED: 6 (6M)

1 review trailer.

3 messages, 3 authors, 2017-03-07 · open the first message on its own page

[PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

From: Hoegeun Kwon <hidden>
Date: 2017-02-22 01:10:29

From: Hyungwon Hwang <redacted>

This patch add the panel device tree node for S6E3HA2 display
controller to TM2 dts.

Signed-off-by: Hyungwon Hwang <redacted>
Signed-off-by: Andrzej Hajda <redacted>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Hoegeun Kwon <redacted>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
---
  arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
  1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts 
b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index dea0a6f..db3fed2 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
@@ -52,6 +52,18 @@
  	assigned-clock-rates = <250000000>, <400000000>;
  };
  +&dsi {
+	panel at 0 {
+		compatible = "samsung,s6e3ha2";
+		reg = <0>;
+		vdd3-supply = <&ldo27_reg>;
+		vci-supply = <&ldo28_reg>;
+		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
+		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+		te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
+	};
+};
+
  &hsi2c_9 {
  	status = "okay";
  -- 1.9.1

Re: [PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

From: Javier Martinez Canillas <hidden>
Date: 2017-03-06 14:42:55

Hello Hoegeun,

On 02/21/2017 10:09 PM, Hoegeun Kwon wrote:
quoted hunk
From: Hyungwon Hwang <redacted>

This patch add the panel device tree node for S6E3HA2 display
controller to TM2 dts.

Signed-off-by: Hyungwon Hwang <redacted>
Signed-off-by: Andrzej Hajda <redacted>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Hoegeun Kwon <redacted>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index dea0a6f..db3fed2 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
@@ -52,6 +52,18 @@
     assigned-clock-rates = <250000000>, <400000000>;
 };
I would add a line here.
 +&dsi {
+    panel at 0 {
+        compatible = "samsung,s6e3ha2";
+        reg = <0>;
+        vdd3-supply = <&ldo27_reg>;
+        vci-supply = <&ldo28_reg>;
+        reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
+        enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+        te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;
+    };
+};
+
Reviewed-by: Javier Martinez Canillas <redacted>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [PATCH v10 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2017-03-07 20:23:31

On Wed, Feb 22, 2017 at 10:09:54AM +0900, Hoegeun Kwon wrote:
From: Hyungwon Hwang <redacted>

This patch add the panel device tree node for S6E3HA2 display
controller to TM2 dts.

Signed-off-by: Hyungwon Hwang <redacted>
Signed-off-by: Andrzej Hajda <redacted>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Hoegeun Kwon <redacted>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)
I tried to apply but:
fatal: corrupt patch at line 37
Patch failed at 0001 arm64: dts: exynos: Add support for S6E3HA2 panel
device on TM2 board

Please fix, rebase, add blank link as suggested by Javier and send a
v11.

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help