[PATCH] DTS: Linksys Board: Add default trigger for sata led

Subsystems: the rest

STALE3517d

3 messages, 3 authors, 2017-02-19 · open the first message on its own page

[PATCH] DTS: Linksys Board: Add default trigger for sata led

From: Ansuel Smith <ansuelsmth@gmail.com>
Date: 2017-02-17 20:42:28

In others board we have the sata led set to funcion with the sata led trigger by default.
This patch makes the same for these board that have sata led but disabled by not associating it to any trigger

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
 3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index f3cee91..a1b6e68 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "caiman:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index 1110718..a1a75af 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "cobra:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 83ac884..dcd73ab 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -156,6 +156,7 @@
 					esata at 4 {
 						label = "mamba:white:esata";
 						reg = <0x4>;
+						linux,default-trigger = "disk-activity";
 					};
 
 					usb2 at 5 {
-- 
1.9.1

Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led

From: Jason Cooper <hidden>
Date: 2017-02-18 14:30:43

Hi Ansuel,

On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
In others board we have the sata led set to funcion with the sata led trigger by default.
This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Please line wrap the commit message.  Other than that,
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: Jason Cooper <redacted>

thx,

Jason.
quoted hunk
---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
 3 files changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/armada-385-linksys-caiman.dts b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
index f3cee91..a1b6e68 100644
--- a/arch/arm/boot/dts/armada-385-linksys-caiman.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-caiman.dts
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "caiman:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/armada-385-linksys-cobra.dts b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
index 1110718..a1a75af 100644
--- a/arch/arm/boot/dts/armada-385-linksys-cobra.dts
+++ b/arch/arm/boot/dts/armada-385-linksys-cobra.dts
@@ -109,6 +109,7 @@
 
 		sata {
 			label = "cobra:white:sata";
+			linux,default-trigger = "disk-activity";
 		};
 	};
 };
diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
index 83ac884..dcd73ab 100644
--- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
+++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts
@@ -156,6 +156,7 @@
 					esata at 4 {
 						label = "mamba:white:esata";
 						reg = <0x4>;
+						linux,default-trigger = "disk-activity";
 					};
 
 					usb2 at 5 {
-- 
1.9.1

Re: [PATCH] DTS: Linksys Board: Add default trigger for sata led

From: Andreas Färber <afaerber@suse.de>
Date: 2017-02-19 00:01:46

Hi,

Am 18.02.2017 um 15:12 schrieb Jason Cooper:
On Fri, Feb 17, 2017 at 09:42:17PM +0100, Ansuel Smith wrote:
quoted
In others board we have the sata led set to funcion with the sata led trigger by default.
This patch makes the same for these board that have sata led but disabled by not associating it to any trigger
Please line wrap the commit message.
The subject could also use some love, like mentioning "ARM:" and
"armada" and dropping "Board". Compare git log --oneline.

Regards,
Andreas
 Other than that,
quoted
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Acked-by: Jason Cooper <redacted>

thx,

Jason.
quoted
---
 arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 +
 arch/arm/boot/dts/armada-385-linksys-cobra.dts  | 1 +
 arch/arm/boot/dts/armada-xp-linksys-mamba.dts   | 1 +
 3 files changed, 3 insertions(+)
-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help