[PATCH] Do not initialise statics to NULL

Subsystems: staging subsystem, the rest

STALE3488d

2 messages, 2 authors, 2017-02-10 · open the first message on its own page

[PATCH] Do not initialise statics to NULL

From: William Stevenson <hidden>
Date: 2017-02-09 22:02:22

This patch fixes a checkpatch.pl error in bcm2835.c

ERROR: do not initialise statics to NULL

Signed-off-by: William Stevenson <redacted>
---
 drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74daccbc..265fe5565f42 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
  * to debug if we run into issues
  */
 
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
 
 static int snd_bcm2835_free(struct bcm2835_chip *chip)
 {
-- 
2.11.1

Re: [PATCH] Do not initialise statics to NULL

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2017-02-10 16:41:37

On Thu, Feb 09, 2017 at 09:57:49PM +0000, William Stevenson wrote:
This patch fixes a checkpatch.pl error in bcm2835.c

ERROR: do not initialise statics to NULL

Signed-off-by: William Stevenson <redacted>
Does not apply to my tree :(
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help