[PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe()

Subsystems: the rest

STALE3477d

2 messages, 2 authors, 2017-03-08 · open the first message on its own page

[PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe()

From: Wei Yongjun <hidden>
Date: 2017-02-06 16:23:09

From: Wei Yongjun <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/soc/zte/zx2967_pm_domains.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soc/zte/zx2967_pm_domains.c b/drivers/soc/zte/zx2967_pm_domains.c
index 61c8d84..c42aeaa 100644
--- a/drivers/soc/zte/zx2967_pm_domains.c
+++ b/drivers/soc/zte/zx2967_pm_domains.c
@@ -125,10 +125,8 @@ int zx2967_pd_probe(struct platform_device *pdev,
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	pcubase = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(pcubase)) {
-		dev_err(&pdev->dev, "ioremap fail.\n");
+	if (IS_ERR(pcubase))
 		return PTR_ERR(pcubase);
-	}
 
 	for (i = 0; i < domain_num; ++i) {
 		zx_pm_domains[i]->power_on = zx2967_power_on;

Re: [PATCH -next] soc: zte: pm_domains: Remove redundant dev_err call in zx2967_pd_probe()

From: Shawn Guo <shawnguo@kernel.org>
Date: 2017-03-08 12:37:05

On Mon, Feb 06, 2017 at 04:23:02PM +0000, Wei Yongjun wrote:
From: Wei Yongjun <redacted>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help