# \[PATCH\] staging: bcm2835: don't mark 'bcm2835\_v4l2\_debug' as static - From: Arnd Bergmann \ - Date: 2017-02-02 12:16:46 - List: linux-arm-kernel - Page: https://ratatoskr.run/linux-arm-kernel/2017/02/4925982 - Thread: https://ratatoskr.run/linux-media/2017/02/4925982/t.md ```text This one unfortunately slipped through my own build testing, my patch caused a new build error: bcm2835-camera.c:53:12: error: static declaration of 'bcm2835_v4l2_debug' follows non-static declaration We want the symbol to be global as it is indeed used in more than one file and declared 'extern' in a header. Fixes: 757b9bd074 ("staging: bcm2835: mark all symbols as 'static'") Signed-off-by: Arnd Bergmann --- drivers/staging/media/platform/bcm2835/bcm2835-camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c b/drivers/staging/media/platform/bcm2835/bcm2835-camera.c index ced8eb5de0f0..ca15a698e018 100644 --- a/drivers/staging/media/platform/bcm2835/bcm2835-camera.c +++ b/drivers/staging/media/platform/bcm2835/bcm2835-camera.c @@ -50,7 +50,7 @@ MODULE_AUTHOR("Vincent Sanders"); MODULE_LICENSE("GPL"); MODULE_VERSION(BM2835_MMAL_VERSION); -static int bcm2835_v4l2_debug; +int bcm2835_v4l2_debug; module_param_named(debug, bcm2835_v4l2_debug, int, 0644); MODULE_PARM_DESC(bcm2835_v4l2_debug, "Debug level 0-2"); -- 2.9.0 ```