[PATCH] perf: xgene: Include module.h

Subsystems: applied micro (apm) x-gene soc pmu, arm pmu profiling and debugging, the rest

STALE3483d

5 messages, 3 authors, 2017-01-26 · open the first message on its own page

[PATCH] perf: xgene: Include module.h

From: Stephen Boyd <hidden>
Date: 2017-01-25 23:47:04 

I ran into a build error when I disabled CONFIG_ACPI and tried to
compile this driver:

drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
 ^
drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

Include module.h for the MODULE_DEVICE_TABLE macro that's
implicitly included through ACPI.

Cc: Tai Nguyen <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/perf/xgene_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index a8ac4bcef2c0..fb3281962a6d 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -20,6 +20,7 @@
  */
 
 #include <linux/acpi.h>
+#include <linux/module.h>
 #include <linux/clk.h>
 #include <linux/cpumask.h>
 #include <linux/interrupt.h>
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH] perf: xgene: Include module.h

From: Tai Tri Nguyen <hidden>
Date: 2017-01-26 02:13:34 

Hi Stephen,

On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd [off-list ref] wrote:
I ran into a build error when I disabled CONFIG_ACPI and tried to
compile this driver:
I tried kernel 4.9 and couldn't reproduce the issue.
What is the kernel version you are seeing the compilation issue?

Regards
Tai
quoted hunk
drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
 ^
drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

Include module.h for the MODULE_DEVICE_TABLE macro that's
implicitly included through ACPI.

Cc: Tai Nguyen <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/perf/xgene_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index a8ac4bcef2c0..fb3281962a6d 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -20,6 +20,7 @@
  */

 #include <linux/acpi.h>
+#include <linux/module.h>
 #include <linux/clk.h>
 #include <linux/cpumask.h>
 #include <linux/interrupt.h>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


-- 
Tai

Re: [PATCH] perf: xgene: Include module.h

From: Tai Tri Nguyen <hidden>
Date: 2017-01-26 02:16:13 

My bad, I can reproduce the issue now.

Thanks
Tai

On Wed, Jan 25, 2017 at 6:13 PM, Tai Tri Nguyen [off-list ref] wrote:
Hi Stephen,

On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd [off-list ref] wrote:
quoted
I ran into a build error when I disabled CONFIG_ACPI and tried to
compile this driver:
I tried kernel 4.9 and couldn't reproduce the issue.
What is the kernel version you are seeing the compilation issue?

Regards
Tai
quoted
drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
 ^
drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

Include module.h for the MODULE_DEVICE_TABLE macro that's
implicitly included through ACPI.

Cc: Tai Nguyen <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/perf/xgene_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index a8ac4bcef2c0..fb3281962a6d 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -20,6 +20,7 @@
  */

 #include <linux/acpi.h>
+#include <linux/module.h>
 #include <linux/clk.h>
 #include <linux/cpumask.h>
 #include <linux/interrupt.h>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


--
Tai


-- 
Tai

Re: [PATCH] perf: xgene: Include module.h

From: Tai Tri Nguyen <hidden>
Date: 2017-01-26 03:29:32 

Hi Stephen,

On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd [off-list ref] wrote:
quoted hunk
I ran into a build error when I disabled CONFIG_ACPI and tried to
compile this driver:

drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
 ^
drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

Include module.h for the MODULE_DEVICE_TABLE macro that's
implicitly included through ACPI.

Cc: Tai Nguyen <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/perf/xgene_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index a8ac4bcef2c0..fb3281962a6d 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -20,6 +20,7 @@
  */

 #include <linux/acpi.h>
+#include <linux/module.h>
Please fix alphabetic order of the include file.

Tested-by: Tai Nguyen <redacted>

 #include <linux/clk.h>
 #include <linux/cpumask.h>
 #include <linux/interrupt.h>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
-- 
Tai

Re: [PATCH] perf: xgene: Include module.h

From: Will Deacon <hidden>
Date: 2017-01-26 12:21:32 

On Wed, Jan 25, 2017 at 07:29:30PM -0800, Tai Tri Nguyen wrote:
On Wed, Jan 25, 2017 at 3:46 PM, Stephen Boyd [off-list ref] wrote:
quoted
I ran into a build error when I disabled CONFIG_ACPI and tried to
compile this driver:

drivers/perf/xgene_pmu.c:1242:1: warning: data definition has no type or storage class
 MODULE_DEVICE_TABLE(of, xgene_pmu_of_match);
 ^
drivers/perf/xgene_pmu.c:1242:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]

Include module.h for the MODULE_DEVICE_TABLE macro that's
implicitly included through ACPI.

Cc: Tai Nguyen <redacted>
Signed-off-by: Stephen Boyd <redacted>
---
 drivers/perf/xgene_pmu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
index a8ac4bcef2c0..fb3281962a6d 100644
--- a/drivers/perf/xgene_pmu.c
+++ b/drivers/perf/xgene_pmu.c
@@ -20,6 +20,7 @@
  */

 #include <linux/acpi.h>
+#include <linux/module.h>
Please fix alphabetic order of the include file.

Tested-by: Tai Nguyen <redacted>
I've picked this up with the includes put in the correct order.

Thanks,

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help