On 10/31/2016 12:12 PM, Joachim Eastwood wrote:

Hi Neil,

On 31 October 2016 at 11:54, Neil Armstrong [off-list ref] wrote:

quoted

Add Synopsys Designware MAC Glue layer for the Oxford Semiconductor OX820.

Acked-by: Joachim Eastwood <redacted>
Signed-off-by: Neil Armstrong <redacted>
---
+static int oxnas_dwmac_init(struct oxnas_dwmac *dwmac)
+{
+       unsigned int value;
+       int ret;
+
+       /* Reset HW here before changing the glue configuration */
+       ret = device_reset(dwmac->dev);
+       if (ret)
+               return ret;
+
+       ret = clk_prepare_enable(dwmac->clk);
+       if (ret)
+               return ret;
+
+       ret = regmap_read(dwmac->regmap, OXNAS_DWMAC_CTRL_REGOFFSET, &value);
+       if (ret < 0)
+               return ret;

If regmap reading fails here, the clock will be left on as probe fails.

Indeed, thanks.

Neil

[...]

regards,
Joachim Eastwood