[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

Subsystems: ethernet phy library, networking drivers, the rest

STALE3666d

6 messages, 4 authors, 2016-08-24 · open the first message on its own page

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: Wei Yongjun <hidden>
Date: 2016-08-23 15:06:05

From: Wei Yongjun <redacted>

Fixes the following sparse warning:

drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
 symbol 'xgmiitorgmii_probe' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index e7a20ec..2e408b8 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
 	return 0;
 }
 
-int xgmiitorgmii_probe(struct mdio_device *mdiodev)
+static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 {
 	struct device *dev = &mdiodev->dev;
 	struct device_node *np = dev->of_node, *phy_node;

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: andrew@lunn.ch (Andrew Lunn)
Date: 2016-08-23 15:16:19

On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
From: Wei Yongjun <redacted>
Hi Wei

No need for the additional From:

git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.

Thanks
    Andrew
quoted hunk
Fixes the following sparse warning:

drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
 symbol 'xgmiitorgmii_probe' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index e7a20ec..2e408b8 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
 	return 0;
 }
 
-int xgmiitorgmii_probe(struct mdio_device *mdiodev)
+static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 {
 	struct device *dev = &mdiodev->dev;
 	struct device_node *np = dev->of_node, *phy_node;

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: Wei Yongjun <hidden>
Date: 2016-08-23 15:41:25

Hi Andrew,

On 08/23/2016 11:16 PM, Andrew Lunn wrote:
On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
quoted
From: Wei Yongjun <redacted>
Hi Wei

No need for the additional From:

git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.
The mail address which I sent the patch is different with the
signed-of-by one, so git send-email will not remove the From line.

Regards,
Yongjun Wei 

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: andrew@lunn.ch (Andrew Lunn)
Date: 2016-08-23 15:50:09

On Tue, Aug 23, 2016 at 11:41:25PM +0800, Wei Yongjun wrote:
Hi Andrew,

On 08/23/2016 11:16 PM, Andrew Lunn wrote:
quoted
On Tue, Aug 23, 2016 at 03:06:05PM +0000, Wei Yongjun wrote:
quoted
From: Wei Yongjun <redacted>
Hi Wei

No need for the additional From:

git am will use the one in the mail header as the author of the patch,
and it is in the signed-off-by as well.
The mail address which I sent the patch is different with the
signed-of-by one, so git send-email will not remove the From line.
Cool. git am strips it out of the commit message and uses it as the
Author. I didn't know it did that.

Sorry for the noise, 

	Andrew

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: Kedari Appana <hidden>
Date: 2016-08-23 16:40:34

HI,

        Thanks for the patch..

On Tue, Aug 23, 2016 at 8:36 PM, Wei Yongjun [off-list ref] wrote:
From: Wei Yongjun <redacted>

Fixes the following sparse warning:

drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
 symbol 'xgmiitorgmii_probe' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
Acked by: Kedareswara rao Appana [off-list ref]
quoted hunk
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index e7a20ec..2e408b8 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -58,7 +58,7 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
        return 0;
 }

-int xgmiitorgmii_probe(struct mdio_device *mdiodev)
+static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 {
        struct device *dev = &mdiodev->dev;
        struct device_node *np = dev->of_node, *phy_node;

[PATCH -next] net: phy: xgmiitorgmii: Fix non static symbol warning

From: davem@davemloft.net (David Miller)
Date: 2016-08-24 00:18:38

From: Wei Yongjun <redacted>
Date: Tue, 23 Aug 2016 15:06:05 +0000
From: Wei Yongjun <redacted>

Fixes the following sparse warning:

drivers/net/phy/xilinx_gmii2rgmii.c:61:5: warning:
 symbol 'xgmiitorgmii_probe' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help