[PATCH 1/2] arm64: Kconfig: select ALPINE_MSI only if PCI is selected

Even when PCI is disabled, ARCH_ALPINE selects ALPINE_MSI triggerring
the following config warning:

warning: (ARCH_ALPINE) selects ALPINE_MSI which has unmet direct
		dependencies (PCI)

This patch makes selection of ALPINE_MSI conditional on PCI.

Cc: Arnd Bergmann <arnd@arndb.de>
Acked-by: Antoine Tenart <redacted>
Signed-off-by: Sudeep Holla <redacted>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Hi ARM-SoC guys,

I still see this couple of config warnings without PCI with today's next.

Regards,
Sudeep

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 4fb0bef0f094..b0e6850aa3e4 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms

@@ -8,7 +8,7 @@ config ARCH_SUNXI

 config ARCH_ALPINE
 	bool "Annapurna Labs Alpine platform"
-	select ALPINE_MSI
+	select ALPINE_MSI if PCI
 	help
 	  This enables support for the Annapurna Labs Alpine
 	  Soc family.
--

2.7.4

Even when PCI is disabled, ARCH_HISI selects HISILICON_IRQ_MBIGEN
triggerring the following config warning:

warning: (ARM64 && HISILICON_IRQ_MBIGEN) selects ARM_GIC_V3_ITS which
	has unmet direct dependencies (PCI && PCI_MSI)

This patch makes selection of HISILICON_IRQ_MBIGEN conditional on PCI.

Cc: Ma Jun <redacted>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sudeep Holla <redacted>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index b0e6850aa3e4..41d82b327e6a 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms

@@ -66,7 +66,7 @@ config ARCH_LG1K
 config ARCH_HISI
 	bool "Hisilicon SoC Family"
 	select ARM_TIMER_SP804
-	select HISILICON_IRQ_MBIGEN
+	select HISILICON_IRQ_MBIGEN if PCI
 	help
 	  This enables support for Hisilicon ARMv8 SoC family

--

2.7.4

On Wednesday, August 3, 2016 3:29:34 PM CEST Sudeep Holla wrote:

Even when PCI is disabled, ARCH_HISI selects HISILICON_IRQ_MBIGEN
triggerring the following config warning:

warning: (ARM64 && HISILICON_IRQ_MBIGEN) selects ARM_GIC_V3_ITS which
        has unmet direct dependencies (PCI && PCI_MSI)

This patch makes selection of HISILICON_IRQ_MBIGEN conditional on PCI.

I think strictly speaking HISILICON_IRQ_MBIGEN should work without PCI,
but that is only a theoretical setup, and the patch seems to be the
simplest way to avoid the warning.

Applied both patches to fixes, sorry for the delay.

	Arnd

? 2016/8/11 4:51, Arnd Bergmann ??:

On Wednesday, August 3, 2016 3:29:34 PM CEST Sudeep Holla wrote:

quoted

Even when PCI is disabled, ARCH_HISI selects HISILICON_IRQ_MBIGEN
triggerring the following config warning:

warning: (ARM64 && HISILICON_IRQ_MBIGEN) selects ARM_GIC_V3_ITS which
        has unmet direct dependencies (PCI && PCI_MSI)

This patch makes selection of HISILICON_IRQ_MBIGEN conditional on PCI.

I think strictly speaking HISILICON_IRQ_MBIGEN should work without PCI,
but that is only a theoretical setup, and the patch seems to be the
simplest way to avoid the warning.

Applied both patches to fixes, sorry for the delay.

sorry for late response, I just noticed this patch.

You are right, HISILICON_IRQ_MBIGEN uses the platform msi and has
no relation with pci.

	Arnd