Re: [PATCH] ARM: dts: da850: Add missing pin muxing for the UARTs

On Thu, Aug 25, 2016 at 07:12:16PM +0530, Sekhar Nori wrote:

On Wednesday 24 August 2016 02:08 PM, Karl Beldan wrote:

quoted

On Tue, Aug 23, 2016 at 04:46:03PM +0530, Sekhar Nori wrote:

quoted

On Tuesday 23 August 2016 04:39 PM, Sekhar Nori wrote:

quoted

On Friday 05 August 2016 04:30 AM, Kevin Hilman wrote:

quoted

Karl Beldan [off-list ref] writes:

quoted

On Thu, Aug 04, 2016 at 12:20:27PM -0700, Kevin Hilman wrote:

quoted

Karl Beldan [off-list ref] writes:

quoted

This adds 2 pinctrl groups (rtscts, rxtx) for each of the 3 UARTs.

Signed-off-by: Karl Beldan <redacted>

Should da850-evm be updated to use the serial2_rxtx_pins also?

I could not find the EVM schematics on the net and I only have an LCDK,
but according to the code it should, however I can't tell whether flow
control pins are used.

Ok, let's just leave it for now, since it's working fine.  Sekhar can
fix that up if he can dig up the schematics.

Looks like the flow control pins are being used for McASP also on the
EVM. So lets leave the EVM as-is.

Rather, the EVM dts file should be updated to use serial2_rxtx_pins like
the LCDK. Right now it seems to be relying on bootloader to serial2
setup pimux correctly. I can make a patch to fix that. Or if you can do
it, that will be great too.

Indeed ATM the EVM relies on the bootloader to setup the pin muxing.

I just checked the uart pins routing of the EVM, the dts:
- should reclaim serial2_rxtx_pins and serial2_rtscts_pins

Can you please clarify what you mean by dts should "reclaim". You mean
move the pins from da850.dtsi to da850-evm.dts or something else?

No, in the part you are replying to I am not referring to moving the
pins but reclaiming them. The pins are declared in the dtsi, as they
should. Eg. the LCDK dts reclaims serial2_rxtx_pins but doesn't reclaim
serial2_rtscts_pins while their declarations remain in the dtsi.

The purpose of this part was to clarify what I saw on the schematics
because your emails include the following 2 statements:

quoted

quoted

quoted

Looks like the flow control pins are being used for McASP also on the
EVM. So lets leave the EVM as-is.

quoted

quoted

Rather, the EVM dts file should be updated to use serial2_rxtx_pins like
the LCDK. Right now it seems to be relying on bootloader to serial2

My email was to inform that it concerns the flow control pins of the
UART1 only and that the UART2 flow control pins are not concerned and, 
since they are dedicated to the UART2, should be reclaimed unlike
in the LCDK.

 
Karl

On Thursday 25 August 2016 07:45 PM, Karl Beldan wrote:

quoted

quoted

Indeed ATM the EVM relies on the bootloader to setup the pin muxing.

I just checked the uart pins routing of the EVM, the dts:
- should reclaim serial2_rxtx_pins and serial2_rtscts_pins

Can you please clarify what you mean by dts should "reclaim". You mean
move the pins from da850.dtsi to da850-evm.dts or something else?

No, in the part you are replying to I am not referring to moving the
pins but reclaiming them. The pins are declared in the dtsi, as they
should. Eg. the LCDK dts reclaims serial2_rxtx_pins but doesn't reclaim
serial2_rtscts_pins while their declarations remain in the dtsi.

Alright. I am not sure if "reclaim" is the right term for this, but it
doesn't matter ;) I understand the intent now.

The purpose of this part was to clarify what I saw on the schematics
because your emails include the following 2 statements:

quoted

quoted

quoted

quoted

Looks like the flow control pins are being used for McASP also on the
EVM. So lets leave the EVM as-is.

quoted

quoted

quoted

Rather, the EVM dts file should be updated to use serial2_rxtx_pins like
the LCDK. Right now it seems to be relying on bootloader to serial2

My email was to inform that it concerns the flow control pins of the
UART1 only and that the UART2 flow control pins are not concerned and, 
since they are dedicated to the UART2, should be reclaimed unlike
in the LCDK.

I see now.

I think I was thrown off by looking at the fact that mcasp0_pins in
da850-evm.dts muxes UART2_RTS as AMUTE. But, its the mcasp0_pins that
needs fixing. AMUTE is not used by audio on the board. As is AFSR. Plus,
that pinmux entry goes and writes to PINMIX0[31:28] the value of 0x1
which is reserved. Sigh.

I will review your original e-mail and reply back.

Thanks,
Sekhar