[PATCH] dt-bindings: touchscreen: silead gsl1680: Document all compatibles

The silead gsl1680 driver / binding supports a whole series of devices,
list the compatibles for all of them in the binding.

Signed-off-by: Hans de Goede <redacted>
---
 .../devicetree/bindings/input/touchscreen/silead_gsl1680.txt         | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
index 1112e0d..37a9370 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt

@@ -2,6 +2,11 @@
 
 Required properties:
 - compatible		  : "silead,gsl1680"
+			or: "silead,gsl1688"
+			or: "silead,gsl3670"
+			or: "silead,gsl3675"
+			or: "silead,gsl3692"
+			or: "silead,mssl1680"
 - reg			  : I2C slave address of the chip (0x40)
 - interrupt-parent	  : a phandle pointing to the interrupt controller
 			    serving the interrupt for this chip

-- 
2.7.4

16.08.2016, 17:06, "Hans de Goede" [off-list ref]:

I think ?mssl1680" is only a string which exists in ACPI tables.
I have disassembled one of my tablet, which is said to have "MSSL1680" in it in
ACPI table (a BayTrail tablet). What I got is a plain GSL1680.
So it shouldn't exist in the compatible list.

?- reg : I2C slave address of the chip (0x40)
?- interrupt-parent : a phandle pointing to the interrupt controller
?????????????????????????????serving the interrupt for this chip
--
2.7.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Hi,

On 17-08-16 04:59, Icenowy Zheng wrote:

16.08.2016, 17:06, "Hans de Goede" [off-list ref]:

quoted

The silead gsl1680 driver / binding supports a whole series of devices,
list the compatibles for all of them in the binding.

Signed-off-by: Hans de Goede <redacted>
---
 .../devicetree/bindings/input/touchscreen/silead_gsl1680.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
index 1112e0d..37a9370 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt
+++ b/Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt

@@ -2,6 +2,11 @@

 Required properties:
 - compatible : "silead,gsl1680"
+ or: "silead,gsl1688"
+ or: "silead,gsl3670"
+ or: "silead,gsl3675"
+ or: "silead,gsl3692"
+ or: "silead,mssl1680"

I think ?mssl1680" is only a string which exists in ACPI tables.
I have disassembled one of my tablet, which is said to have "MSSL1680" in it in
ACPI table (a BayTrail tablet). What I got is a plain GSL1680.
So it shouldn't exist in the compatible list.

Ah, right, I was already wondering about that one I guess mssl stands for
"microsoft silead" (just a guess). Anyways I'll send a v2 dropping it.

Thanks & Regards,

Hans

quoted

 - reg : I2C slave address of the chip (0x40)
 - interrupt-parent : a phandle pointing to the interrupt controller
                             serving the interrupt for this chip
--
2.7.4

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel