Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

2 messages, 2 authors, 2016-08-23 · open the first message on its own page

Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: 2016-08-23 16:25:25

Wei Yongjun [off-list ref] writes:
Remove duplicated include.
How so duplicated ? Can you elaborate please ?

Moreover, how do you do think symbol_get() can stay in spitz.c without having
this include ?

Cheers.

--
Robert

Re: [PATCH -next] ARM: pxa: remove duplicated include from spitz.c

From: Wei Yongjun <hidden>
Date: 2016-08-23 16:43:22

Hi Robert,
 

On 08/24/2016 12:24 AM, Robert Jarzmik wrote:
Wei Yongjun [off-list ref] writes:
quoted
Remove duplicated include.
How so duplicated ? Can you elaborate please ?

Moreover, how do you do think symbol_get() can stay in spitz.c without having
this include ?
file linux/module.h included twice as following:

#include <linux/kernel.h>
#include <linux/module.h>       /* symbol_get ; symbol_put */
...
#include <linux/module.h>

So I think we can remove the dup include.

Regards,
Wei Yongjun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help