[PATCH] exynos-drm: Fix error messages to print flags and size

Subsystems: drm drivers, drm drivers for exynos, the rest

STALE3619d

4 messages, 4 authors, 2016-10-19 · open the first message on its own page

[PATCH] exynos-drm: Fix error messages to print flags and size

From: Shuah Khan <hidden>
Date: 2016-08-10 18:03:49

Fix exynos_drm_gem_create() error messages to include flags and size when
flags and size are invalid.

Signed-off-by: Shuah Khan <redacted>
---
 drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index cdf9f1a..4c4cb0e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
 	int ret;
 
 	if (flags & ~(EXYNOS_BO_MASK)) {
-		DRM_ERROR("invalid flags.\n");
+		DRM_ERROR("invalid GEM buffer flags: %u\n", flags);
 		return ERR_PTR(-EINVAL);
 	}
 
 	if (!size) {
-		DRM_ERROR("invalid size.\n");
+		DRM_ERROR("invalid GEM buffer size: %lu\n", size);
 		return ERR_PTR(-EINVAL);
 	}
 
-- 
2.7.4

Re: [PATCH] exynos-drm: Fix error messages to print flags and size

From: Javier Martinez Canillas <javier@dowhile0.org>
Date: 2016-08-10 18:11:34

Hello Shuah,

On Wed, Aug 10, 2016 at 1:30 PM, Shuah Khan [off-list ref] wrote:
Fix exynos_drm_gem_create() error messages to include flags and size when
flags and size are invalid.

Signed-off-by: Shuah Khan <redacted>
---
Reviewed-by: Javier Martinez Canillas <redacted>

Best regards,
Javier

Re: [PATCH] exynos-drm: Fix error messages to print flags and size

From: Tobias Jakobi <hidden>
Date: 2016-10-06 13:09:48

Hello,

I think this patch was never picked up. So just a short 'ping' from my side.

With best wishes,
Tobias


Shuah Khan wrote:
quoted hunk
Fix exynos_drm_gem_create() error messages to include flags and size when
flags and size are invalid.

Signed-off-by: Shuah Khan <redacted>
---
 drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index cdf9f1a..4c4cb0e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
 	int ret;
 
 	if (flags & ~(EXYNOS_BO_MASK)) {
-		DRM_ERROR("invalid flags.\n");
+		DRM_ERROR("invalid GEM buffer flags: %u\n", flags);
 		return ERR_PTR(-EINVAL);
 	}
 
 	if (!size) {
-		DRM_ERROR("invalid size.\n");
+		DRM_ERROR("invalid GEM buffer size: %lu\n", size);
 		return ERR_PTR(-EINVAL);
 	}
 

Re: [PATCH] exynos-drm: Fix error messages to print flags and size

From: Inki Dae <hidden>
Date: 2016-10-19 14:32:23

2016-10-06 22:09 GMT+09:00 Tobias Jakobi [off-list ref]:
Hello,

I think this patch was never picked up. So just a short 'ping' from my side.
Oops. one I missed. Will pick it up soon.

Thanks,
Inki Dae
With best wishes,
Tobias


Shuah Khan wrote:
quoted
Fix exynos_drm_gem_create() error messages to include flags and size when
flags and size are invalid.

Signed-off-by: Shuah Khan <redacted>
---
 drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
index cdf9f1a..4c4cb0e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
@@ -231,12 +231,12 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
      int ret;

      if (flags & ~(EXYNOS_BO_MASK)) {
-             DRM_ERROR("invalid flags.\n");
+             DRM_ERROR("invalid GEM buffer flags: %u\n", flags);
              return ERR_PTR(-EINVAL);
      }

      if (!size) {
-             DRM_ERROR("invalid size.\n");
+             DRM_ERROR("invalid GEM buffer size: %lu\n", size);
              return ERR_PTR(-EINVAL);
      }
_______________________________________________
dri-devel mailing list
dri-devel at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help