From: John Stultz <hidden> Date: 2016-08-08 23:03:58
Add support to hikey dts for the syscon-reboot-mode driver.
After trying an approach using a sram driver and node, a number
of issues cropped up which would make it so we would be
duplicating a lot of extra syscon infrastructure in order to
support mfds on sram. After talking with Bjorn, using the
syscon driver for this seems like an better choice.
Cc: Andy Yan <andy.yan@rock-chips.com>
Cc: Bjorn Andersson <redacted>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Guodong Xu <redacted>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Signed-off-by: John Stultz <redacted>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
From: John Stultz <hidden> Date: 2016-08-08 23:04:10
This patch reserves some memory in the DTS and sets up a
pstore device tree node to enable pstore support on HiKey.
Cc: Kees Cook <redacted>
Cc: Guodong Xu <redacted>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Signed-off-by: John Stultz <redacted>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
@@ -379,4 +379,36 @@&dsi{status="ok";++ports{+/* 1 for output port */+portat1{+reg=<1>;++dsi_out0:endpointat0{+remote-endpoint=<&adv7533_in>;+};+};+};+};++&i2c2{+#address-cells=<1>;+#size-cells=<0>;+status="ok";++adv7533:adv7533at39{+compatible="adi,adv7533";+reg=<0x39>;+interrupt-parent=<&gpio1>;+interrupts=<12>;+pd-gpio=<&gpio040>;+adi,dsi-lanes=<4>;++port{+adv7533_in:endpoint{+remote-endpoint=<&dsi_out0>;+};+};+};};
On Mon, Aug 8, 2016 at 4:03 PM, John Stultz [off-list ref] wrote:
quoted hunk
This patch reserves some memory in the DTS and sets up a
pstore device tree node to enable pstore support on HiKey.
Cc: Kees Cook <redacted>
Cc: Guodong Xu <redacted>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Signed-off-by: John Stultz <redacted>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
From: John Stultz <hidden> Date: 2016-08-08 23:24:00
On Mon, Aug 8, 2016 at 4:20 PM, Kees Cook [off-list ref] wrote:
On Mon, Aug 8, 2016 at 4:03 PM, John Stultz [off-list ref] wrote:
quoted
This patch reserves some memory in the DTS and sets up a
pstore device tree node to enable pstore support on HiKey.
Cc: Kees Cook <redacted>
Cc: Guodong Xu <redacted>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Signed-off-by: John Stultz <redacted>
---
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
From: John Stultz <hidden> Date: 2016-08-08 23:48:50
This patch reserves some memory in the DTS and sets up a
pstore device tree node to enable pstore support on HiKey.
Cc: Kees Cook <redacted>
Cc: Guodong Xu <redacted>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Signed-off-by: John Stultz <redacted>
---
v2: Quick rework to update to new ramoops format.
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
On Mon, Aug 8, 2016 at 4:48 PM, John Stultz [off-list ref] wrote:
This patch reserves some memory in the DTS and sets up a
pstore device tree node to enable pstore support on HiKey.
Cc: Kees Cook <redacted>
Cc: Guodong Xu <redacted>
Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: devicetree at vger.kernel.org
Signed-off-by: John Stultz <redacted>
This looks right to me. :)
Reviewed-by: Kees Cook <redacted>
quoted hunk
---
v2: Quick rework to update to new ramoops format.
arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
As I said when talked about this, I don't think you should punch holes
in the /memory node, but rather add these regions as no-map in a
/reserved-memory node. But that's a unrelated matter.
As I said when talked about this, I don't think you should punch holes
in the /memory node, but rather add these regions as no-map in a
/reserved-memory node. But that's a unrelated matter.
Yea. I need to sync w/ Wei and Guodong to see about reworking all of
those to use /reserved-memory, but for now I'd like to stay in sync w/
how they have it setup.
As I said when talked about this, I don't think you should punch holes
in the /memory node, but rather add these regions as no-map in a
/reserved-memory node. But that's a unrelated matter.
Yea. I need to sync w/ Wei and Guodong to see about reworking all of
those to use /reserved-memory, but for now I'd like to stay in sync w/
how they have it setup.
Both are fine to me.
I remember before we had a discussion [1].
How about we add these functions this time and clean the memory node
in the future if needed?
[1] http://patches.linaro.org/patch/54682/
Best Regards,
Wei
As I said when talked about this, I don't think you should punch holes
in the /memory node, but rather add these regions as no-map in a
/reserved-memory node. But that's a unrelated matter.
Yea. I need to sync w/ Wei and Guodong to see about reworking all of
those to use /reserved-memory, but for now I'd like to stay in sync w/
how they have it setup.
Both are fine to me.
I remember before we had a discussion [1].
How about we add these functions this time and clean the memory node
in the future if needed?
[1] http://patches.linaro.org/patch/54682/
I agree, you should not hold up John's addition on changing to
reserve-memory, as these are unrelated changes..
But I would recommend that you take the time to do the switch to
/reserve-memory before next change to /memory comes in, as that change
will be just as unrelated.
Regards,
Bjorn