[PATCH v2 2/2] imx53.dtsi : Add DMA configuration for UART

Subsystems: the rest

STALE3662d

4 messages, 4 authors, 2016-08-09 · open the first message on its own page

[PATCH v2 2/2] imx53.dtsi : Add DMA configuration for UART

From: Fabien Lahoudere <hidden>
Date: 2016-08-04 10:25:57

In order to use sdma with UART, we need to add DMA configuration in device tree.

Signed-off-by: Fabien Lahoudere <redacted>
---
 arch/arm/boot/dts/imx53.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index cd17037..c1bc97c 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -217,6 +217,8 @@
 					clocks = <&clks IMX5_CLK_UART3_IPG_GATE>,
 					         <&clks IMX5_CLK_UART3_PER_GATE>;
 					clock-names = "ipg", "per";
+					dmas = <&sdma 42 4 0>, <&sdma 43 4 0>;
+					dma-names = "rx", "tx";
 					status = "disabled";
 				};
 
@@ -498,6 +500,8 @@
 				clocks = <&clks IMX5_CLK_UART1_IPG_GATE>,
 				         <&clks IMX5_CLK_UART1_PER_GATE>;
 				clock-names = "ipg", "per";
+				dmas = <&sdma 18 4 0>, <&sdma 19 4 0>;
+				dma-names = "rx", "tx";
 				status = "disabled";
 			};
 
@@ -508,6 +512,8 @@
 				clocks = <&clks IMX5_CLK_UART2_IPG_GATE>,
 				         <&clks IMX5_CLK_UART2_PER_GATE>;
 				clock-names = "ipg", "per";
+				dmas = <&sdma 12 4 0>, <&sdma 13 4 0>;
+				dma-names = "rx", "tx";
 				status = "disabled";
 			};
 
@@ -591,6 +597,8 @@
 				clocks = <&clks IMX5_CLK_UART4_IPG_GATE>,
 				         <&clks IMX5_CLK_UART4_PER_GATE>;
 				clock-names = "ipg", "per";
+				dmas = <&sdma 2 4 0>, <&sdma 3 4 0>;
+				dma-names = "rx", "tx";
 				status = "disabled";
 			};
 		};
@@ -621,6 +629,8 @@
 				clocks = <&clks IMX5_CLK_UART5_IPG_GATE>,
 				         <&clks IMX5_CLK_UART5_PER_GATE>;
 				clock-names = "ipg", "per";
+				dmas = <&sdma 16 4 0>, <&sdma 17 4 0>;
+				dma-names = "rx", "tx";
 				status = "disabled";
 			};
 
-- 
2.7.4

Re: [PATCH v2 2/2] imx53.dtsi : Add DMA configuration for UART

From: Alexander Shiyan <hidden>
Date: 2016-08-04 11:20:06

???????,  4 ??????? 2016, 13:22 +03:00 ?? Fabien Lahoudere [off-list ref]:

In order to use sdma with UART, we need to add DMA configuration in device tree.

Signed-off-by: Fabien Lahoudere < fabien.lahoudere@collabora.co.uk >
---
?arch/arm/boot/dts/imx53.dtsi | 10 ++++++++++
?1 file changed, 10 insertions(+)
...

Hello.

UART SDMA has been tested by me for i.MX51.
So, on my opinion, In the first part of the patch, we just need to remove is_imx6q_uart()
check on and always let the devicetree decide about DMA usage.

Thanks.
---

Re: [PATCH v2 2/2] imx53.dtsi : Add DMA configuration for UART

From: Fabio Estevam <festevam@gmail.com>
Date: 2016-08-06 20:04:41

On Thu, Aug 4, 2016 at 7:49 AM, Alexander Shiyan [off-list ref] wrote:
Hello.

UART SDMA has been tested by me for i.MX51.
So, on my opinion, In the first part of the patch, we just need to remove is_imx6q_uart()
check on and always let the devicetree decide about DMA usage.
Yes, agreed.

Re: [PATCH v2 2/2] imx53.dtsi : Add DMA configuration for UART

From: Shawn Guo <shawnguo@kernel.org>
Date: 2016-08-09 13:35:50

On Thu, Aug 04, 2016 at 12:22:37PM +0200, Fabien Lahoudere wrote:
In order to use sdma with UART, we need to add DMA configuration in device tree.

Signed-off-by: Fabien Lahoudere <redacted>
Changed subject prefix to 'ARM: dts: imx53: ', and applied patch.

Shawn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help