[PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status

Subsystems: arm port, the rest

STALE3734d

2 messages, 2 authors, 2016-06-17 · open the first message on its own page

[PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status

From: Ben Dooks <hidden>
Date: 2016-06-17 15:05:05

The function pcibios_report_status() needs a declaration to avoid
the following warning, so declare it in <asm/pci.h>.

/home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
---
Cc: linux-arm-kernel at lists.infradead.org
Cc: Russell King <linux@armlinux.org.uk>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/arm/include/asm/pci.h | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h
index 057d381..4b5ea93 100644
--- a/arch/arm/include/asm/pci.h
+++ b/arch/arm/include/asm/pci.h
@@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
 	return channel ? 15 : 14;
 }
 
+extern void pcibios_report_status(unsigned int status_mask, int warn);
+
 #endif /* __KERNEL__ */
 #endif
-- 
2.8.1

[PATCH 1/9] ARM/PCI: Add declaration of pcibios_report_status

From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-06-17 15:27:31

On Friday, June 17, 2016 4:05:05 PM CEST Ben Dooks wrote:
quoted hunk
The function pcibios_report_status() needs a declaration to avoid
the following warning, so declare it in <asm/pci.h>.

/home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
---
Cc: linux-arm-kernel at lists.infradead.org
Cc: Russell King <linux@armlinux.org.uk>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 arch/arm/include/asm/pci.h | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h
index 057d381..4b5ea93 100644
--- a/arch/arm/include/asm/pci.h
+++ b/arch/arm/include/asm/pci.h
@@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel)
 	return channel ? 15 : 14;
 }
 
+extern void pcibios_report_status(unsigned int status_mask, int warn);
+
 #endif /* __KERNEL__ */
 #endif
Should we remove the declaration in arch/arm/mach-footbridge/dc21285.c
at the same time?

Another option would be to move the function to that file and make
it static, since nothing else uses it.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help