From: Ben Dooks <hidden> Date: 2016-06-08 16:54:57
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
Signed-off-by: Ben Dooks <redacted>
---
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
arch/arm/mach-tegra/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
Signed-off-by: Ben Dooks <redacted>
---
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
arch/arm/mach-tegra/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160610/ffcc37ab/attachment.sig>
* PGP Signed by an unknown key
On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
quoted
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
Signed-off-by: Ben Dooks <redacted>
---
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
arch/arm/mach-tegra/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.
On Fri, Jun 10, 2016 at 03:33:25PM +0100, Jon Hunter wrote:
On 10/06/16 15:22, Thierry Reding wrote:
quoted
* PGP Signed by an unknown key
On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
quoted
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
Signed-off-by: Ben Dooks <redacted>
---
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
arch/arm/mach-tegra/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.
From: Ben Dooks <hidden> Date: 2016-06-10 15:02:16
On 10/06/16 15:33, Jon Hunter wrote:
On 10/06/16 15:22, Thierry Reding wrote:
quoted
* PGP Signed by an unknown key
On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
quoted
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
Signed-off-by: Ben Dooks <redacted>
---
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
arch/arm/mach-tegra/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.
Given it is likely that gcc warning flags will be updated
it'd be good to get these issues sorted out.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
* PGP Signed by an unknown key
On Fri, Jun 10, 2016 at 03:33:25PM +0100, Jon Hunter wrote:
quoted
On 10/06/16 15:22, Thierry Reding wrote:
quoted
quoted
Old Signed by an unknown key
On Wed, Jun 08, 2016 at 05:54:57PM +0100, Ben Dooks wrote:
quoted
The prototype of tegra_cpuidle_pcie_irqs_in_use() is missing
from the cpuidle.c file, it is defined in <soc/tegra/cpuidle.h>
so add that include to avoid the following warning:
arch/arm/mach-tegra/cpuidle.c:51:6: warning: symbol 'tegra_cpuidle_pcie_irqs_in_use' was not declared. Should it be static?
Signed-off-by: Ben Dooks <redacted>
---
Cc: Stephen Warren <redacted>
Cc: Alexandre Courbot <redacted>
Cc: Thierry Reding <redacted>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-tegra at vger.kernel.org
---
arch/arm/mach-tegra/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
I've been carrying a set of patches to fix these, and a couple of other
sparse warnings, in my tree locally, but never sent them out because
they were so trivial. I probably should've to avoid the duplication of
effort. Sorry about that.