[PATCH] soc: brcmstb: fix warning from missing include

Subsystems: the rest

STALE3758d

2 messages, 2 authors, 2016-06-07 · open the first message on its own page

[PATCH] soc: brcmstb: fix warning from missing include

From: Ben Dooks <hidden>
Date: 2016-06-07 17:54:54

The brcmstb_biuctrl_init() is defined in the soc specific header
file, but wasn't included in the driver file. Fix the following
warning by including <linux/soc/brcmstb/brcmstb.h> in the driver:

drivers/soc/brcmstb/biuctrl.c:101:13: warning: symbol 'brcmstb_biuctrl_init' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
---
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Gregory Fong <redacted>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: bcm-kernel-feedback-list at broadcom.com
---
 drivers/soc/brcmstb/biuctrl.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/soc/brcmstb/biuctrl.c b/drivers/soc/brcmstb/biuctrl.c
index 9049c076f..3c39415 100644
--- a/drivers/soc/brcmstb/biuctrl.c
+++ b/drivers/soc/brcmstb/biuctrl.c
@@ -19,6 +19,7 @@
 #include <linux/io.h>
 #include <linux/of_address.h>
 #include <linux/syscore_ops.h>
+#include <linux/soc/brcmstb/brcmstb.h>
 
 #define CPU_CREDIT_REG_OFFSET			0x184
 #define  CPU_CREDIT_REG_MCPx_WR_PAIRING_EN_MASK	0x70000000
-- 
2.8.1

[PATCH] soc: brcmstb: fix warning from missing include

From: f.fainelli@gmail.com (Florian Fainelli)
Date: 2016-06-07 20:53:58

On 06/07/2016 10:54 AM, Ben Dooks wrote:
The brcmstb_biuctrl_init() is defined in the soc specific header
file, but wasn't included in the driver file. Fix the following
warning by including <linux/soc/brcmstb/brcmstb.h> in the driver:

drivers/soc/brcmstb/biuctrl.c:101:13: warning: symbol 'brcmstb_biuctrl_init' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
Applied, thanks Ben!
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help