[PATCH] ARM: dts: imx6qdl-sabresd: Pass the correct PCI reset polarity

Subsystems: the rest

STALE3741d

2 messages, 2 authors, 2016-06-11 · open the first message on its own page

[PATCH] ARM: dts: imx6qdl-sabresd: Pass the correct PCI reset polarity

From: festevam@gmail.com (Fabio Estevam)
Date: 2016-06-06 02:00:47

From: Fabio Estevam <redacted>

The PCI reset GPIO is active low, so represent it with the
GPIO_ACTIVE_LOW flag.

Even though the imx6 PCI driver will not take the polarity into account
in this case, it is better to provide a correct description in device-tree.

Signed-off-by: Fabio Estevam <redacted>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 5248e7b..bea707f 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -533,7 +533,7 @@
 &pcie {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pcie>;
-	reset-gpio = <&gpio7 12 0>;
+	reset-gpio = <&gpio7 12 GPIO_ACTIVE_LOW>;
 	status = "okay";
 };
 
-- 
1.9.1

[PATCH] ARM: dts: imx6qdl-sabresd: Pass the correct PCI reset polarity

From: shawnguo@kernel.org (Shawn Guo)
Date: 2016-06-11 09:36:06

On Sun, Jun 05, 2016 at 11:00:47PM -0300, Fabio Estevam wrote:
From: Fabio Estevam <redacted>

The PCI reset GPIO is active low, so represent it with the
GPIO_ACTIVE_LOW flag.

Even though the imx6 PCI driver will not take the polarity into account
in this case, it is better to provide a correct description in device-tree.

Signed-off-by: Fabio Estevam <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help