[PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static

Subsystems: common clk framework, the rest

STALE3733d

3 messages, 3 authors, 2016-06-21 · open the first message on its own page

[PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static

From: Ben Dooks <hidden>
Date: 2016-06-07 16:38:09

The of_sama5d2_clk_generated_setup() is not exported outside
of the driver, so make it static to fix the warning about it
being not static:

drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
---
Cc: Boris Brezillon <redacted>
Cc: Michael Turquette <redacted>
Cc: Stephen Boyd <redacted>
Cc: linux-clk at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
---
 drivers/clk/at91/clk-generated.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
index e1aa210..7f6bec8 100644
--- a/drivers/clk/at91/clk-generated.c
+++ b/drivers/clk/at91/clk-generated.c
@@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap,  spinlock_t *lock, const char
 	return clk;
 }
 
-void __init of_sama5d2_clk_generated_setup(struct device_node *np)
+static void __init of_sama5d2_clk_generated_setup(struct device_node *np)
 {
 	int num;
 	u32 id;
-- 
2.8.1

Re: [PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static

From: Boris Brezillon <hidden>
Date: 2016-06-07 16:41:39

On Tue,  7 Jun 2016 17:38:09 +0100
Ben Dooks [off-list ref] wrote:
The of_sama5d2_clk_generated_setup() is not exported outside
of the driver, so make it static to fix the warning about it
being not static:

drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
Acked-by: Boris Brezillon <redacted>
quoted hunk
---
Cc: Boris Brezillon <redacted>
Cc: Michael Turquette <redacted>
Cc: Stephen Boyd <redacted>
Cc: linux-clk at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org
---
 drivers/clk/at91/clk-generated.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/at91/clk-generated.c b/drivers/clk/at91/clk-generated.c
index e1aa210..7f6bec8 100644
--- a/drivers/clk/at91/clk-generated.c
+++ b/drivers/clk/at91/clk-generated.c
@@ -267,7 +267,7 @@ at91_clk_register_generated(struct regmap *regmap,  spinlock_t *lock, const char
 	return clk;
 }
 
-void __init of_sama5d2_clk_generated_setup(struct device_node *np)
+static void __init of_sama5d2_clk_generated_setup(struct device_node *np)
 {
 	int num;
 	u32 id;


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH] clk: at91: make of_sama5d2_clk_generated_setup() static

From: Stephen Boyd <hidden>
Date: 2016-06-21 00:44:38

On 06/07, Ben Dooks wrote:
The of_sama5d2_clk_generated_setup() is not exported outside
of the driver, so make it static to fix the warning about it
being not static:

drivers/clk/at91/clk-generated.c:270:13: warning: symbol 'of_sama5d2_clk_generated_setup' was not declared. Should it be static?

Signed-off-by: Ben Dooks <redacted>
---
Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help