[PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required

Subsystems: drm drivers, drm drivers and misc gpu patches, drm drivers for atmel hlcdc, the rest

STALE3771d

2 messages, 2 authors, 2016-06-02 · open the first message on its own page

[PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required

From: Boris Brezillon <hidden>
Date: 2016-06-01 11:43:05

The driver is only enabling scaling, but never disabling it, thus, if you
enable the scaling feature once it stays enabled forever.

Signed-off-by: Boris Brezillon <redacted>
Reported-by: Alex Vazquez <redacted>
Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
Cc: <redacted>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index aef3ca8..016c191 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
 
 		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
 					     factor_reg);
+	} else {
+		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
 	}
 }
 
-- 
2.7.4

Re: [PATCH] drm: atmel-hlcdc: actually disable scaling when no scaling is required

From: Nicolas Ferre <hidden>
Date: 2016-06-02 09:44:15

Le 01/06/2016 13:42, Boris Brezillon a ?crit :
The driver is only enabling scaling, but never disabling it, thus, if you
enable the scaling feature once it stays enabled forever.

Signed-off-by: Boris Brezillon <redacted>
Reported-by: Alex Vazquez <redacted>
Fixes: 1a396789f65a ("drm: add Atmel HLCDC Display Controller support")
Cc: <redacted>
Reviewed-by: Nicolas Ferre <redacted>

Thanks!
quoted hunk
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index aef3ca8..016c191 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -339,6 +339,8 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
 
 		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff,
 					     factor_reg);
+	} else {
+		atmel_hlcdc_layer_update_cfg(&plane->layer, 13, 0xffffffff, 0);
 	}
 }
 

-- 
Nicolas Ferre
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help