[PATCH] arm64: tegra: Add missing Smaug revision

Subsystems: the rest

STALE3638d

5 messages, 4 authors, 2016-09-16 · open the first message on its own page

[PATCH] arm64: tegra: Add missing Smaug revision

From: Alexandre Courbot <acourbot@nvidia.com>
Date: 2016-06-29 08:52:46

The "google,smaug-rev2" string is missing from the compatible list of
Smaug's DT. The differences of rev2 are not relevant at our current
level of support and it boots just fine, so add it.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 431266a48e9c..82a96bd27bc8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -11,7 +11,8 @@
 	compatible = "google,smaug-rev8", "google,smaug-rev7",
 		     "google,smaug-rev6", "google,smaug-rev5",
 		     "google,smaug-rev4", "google,smaug-rev3",
-		     "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+		     "google,smaug-rev2", "google,smaug-rev1",
+		     "google,smaug", "nvidia,tegra210";
 
 	aliases {
 		serial0 = &uarta;
-- 
2.9.0

Re: [PATCH] arm64: tegra: Add missing Smaug revision

From: Jon Hunter <jonathanh@nvidia.com>
Date: 2016-06-29 09:03:10

On 29/06/16 09:52, Alexandre Courbot wrote:
quoted hunk
The "google,smaug-rev2" string is missing from the compatible list of
Smaug's DT. The differences of rev2 are not relevant at our current
level of support and it boots just fine, so add it.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 431266a48e9c..82a96bd27bc8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -11,7 +11,8 @@
 	compatible = "google,smaug-rev8", "google,smaug-rev7",
 		     "google,smaug-rev6", "google,smaug-rev5",
 		     "google,smaug-rev4", "google,smaug-rev3",
-		     "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+		     "google,smaug-rev2", "google,smaug-rev1",
+		     "google,smaug", "nvidia,tegra210";
 
 	aliases {
 		serial0 = &uarta;
Acked-by: Jon Hunter <jonathanh@nvidia.com>

Olof, let us know if you have any comments on this? Looks like I missed
this initially because the rev2 support had been broken out in the
chrome-os kernel tree to support some specific features for this board.
However, I think for now it is ok to include rev2 here as well for mainline.

Cheers
Jon

-- 
nvpublic

Re: [PATCH] arm64: tegra: Add missing Smaug revision

From: Alexandre Courbot <hidden>
Date: 2016-06-30 06:04:44

On Wed, Jun 29, 2016 at 6:02 PM, Jon Hunter [off-list ref] wrote:
On 29/06/16 09:52, Alexandre Courbot wrote:
quoted
The "google,smaug-rev2" string is missing from the compatible list of
Smaug's DT. The differences of rev2 are not relevant at our current
level of support and it boots just fine, so add it.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 431266a48e9c..82a96bd27bc8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -11,7 +11,8 @@
      compatible = "google,smaug-rev8", "google,smaug-rev7",
                   "google,smaug-rev6", "google,smaug-rev5",
                   "google,smaug-rev4", "google,smaug-rev3",
-                  "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+                  "google,smaug-rev2", "google,smaug-rev1",
+                  "google,smaug", "nvidia,tegra210";

      aliases {
              serial0 = &uarta;
Acked-by: Jon Hunter <jonathanh@nvidia.com>

Olof, let us know if you have any comments on this? Looks like I missed
this initially because the rev2 support had been broken out in the
chrome-os kernel tree to support some specific features for this board.
However, I think for now it is ok to include rev2 here as well for mainline.
This should be perfectly safe. If I run a diff between
tegra210-smaug-p1.dts and tegra210-smaug-p2.dts in the ChromeOS tree,
the only node that differs is sysedp-batmon-calc. The other node in
these files (spiflash) is identical.

Besides I don't think there are that many rev2s out there. :)

Re: [PATCH] arm64: tegra: Add missing Smaug revision

From: Andrew Bresticker <hidden>
Date: 2016-06-30 16:15:50

On Wed, Jun 29, 2016 at 1:52 AM, Alexandre Courbot [off-list ref] wrote:
The "google,smaug-rev2" string is missing from the compatible list of
Smaug's DT. The differences of rev2 are not relevant at our current
level of support and it boots just fine, so add it.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Andrew Bresticker <redacted>
quoted hunk
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 431266a48e9c..82a96bd27bc8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -11,7 +11,8 @@
        compatible = "google,smaug-rev8", "google,smaug-rev7",
                     "google,smaug-rev6", "google,smaug-rev5",
                     "google,smaug-rev4", "google,smaug-rev3",
-                    "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+                    "google,smaug-rev2", "google,smaug-rev1",
+                    "google,smaug", "nvidia,tegra210";

        aliases {
                serial0 = &uarta;
--
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] arm64: tegra: Add missing Smaug revision

From: Alexandre Courbot <hidden>
Date: 2016-09-16 08:20:27

Not seeing this patch in -next, can someone pick it?

On Fri, Jul 1, 2016 at 1:15 AM, Andrew Bresticker [off-list ref] wrote:
On Wed, Jun 29, 2016 at 1:52 AM, Alexandre Courbot [off-list ref] wrote:
quoted
The "google,smaug-rev2" string is missing from the compatible list of
Smaug's DT. The differences of rev2 are not relevant at our current
level of support and it boots just fine, so add it.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Andrew Bresticker <redacted>
quoted
---
 arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
index 431266a48e9c..82a96bd27bc8 100644
--- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts
@@ -11,7 +11,8 @@
        compatible = "google,smaug-rev8", "google,smaug-rev7",
                     "google,smaug-rev6", "google,smaug-rev5",
                     "google,smaug-rev4", "google,smaug-rev3",
-                    "google,smaug-rev1", "google,smaug", "nvidia,tegra210";
+                    "google,smaug-rev2", "google,smaug-rev1",
+                    "google,smaug", "nvidia,tegra210";

        aliases {
                serial0 = &uarta;
--
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help