[PATCH] arm64: add boot image dependencies to not generate invalid images

Subsystems: arm64 port (aarch64 architecture), the rest

STALE3731d

4 messages, 3 authors, 2016-06-21 · open the first message on its own page

[PATCH] arm64: add boot image dependencies to not generate invalid images

From: Masahiro Yamada <hidden>
Date: 2016-06-21 01:48:50

I fixed boot image dependencies for arch/arm in commit 3939f3345050
("ARM: 8418/1: add boot image dependencies to not generate invalid
images").

I see a similar problem for arch/arm64; "make -jN Image Image.gz"
would sometimes end up generating bad images where N > 1.

Fix the dependency in arch/arm64/Makefile to avoid the race
between "make Image" and "make Image.*".

Signed-off-by: Masahiro Yamada <redacted>
---

 arch/arm64/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 7085e32..648a32c 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -95,7 +95,7 @@ boot := arch/arm64/boot
 Image: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
 
-Image.%: vmlinux
+Image.%: Image
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
 
 zinstall install:
-- 
1.9.1

Re: [PATCH] arm64: add boot image dependencies to not generate invalid images

From: Masahiro Yamada <hidden>
Date: 2016-06-21 10:37:32

2016-06-21 19:32 GMT+09:00 Catalin Marinas [off-list ref]:
On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote:
quoted
I fixed boot image dependencies for arch/arm in commit 3939f3345050
("ARM: 8418/1: add boot image dependencies to not generate invalid
images").

I see a similar problem for arch/arm64; "make -jN Image Image.gz"
would sometimes end up generating bad images where N > 1.

Fix the dependency in arch/arm64/Makefile to avoid the race
between "make Image" and "make Image.*".

Signed-off-by: Masahiro Yamada <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Will, could you please pick this up for 4.7? Maybe with a cc stable.
Thanks.

If possible, could you change the subject?


arm64: add boot image dependencies to not generate invalid images

 --->

arm64: fix boot image dependencies to not generate invalid images



-- 
Best Regards
Masahiro Yamada

Re: [PATCH] arm64: add boot image dependencies to not generate invalid images

From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2016-06-21 13:38:18

On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote:
I fixed boot image dependencies for arch/arm in commit 3939f3345050
("ARM: 8418/1: add boot image dependencies to not generate invalid
images").

I see a similar problem for arch/arm64; "make -jN Image Image.gz"
would sometimes end up generating bad images where N > 1.

Fix the dependency in arch/arm64/Makefile to avoid the race
between "make Image" and "make Image.*".

Signed-off-by: Masahiro Yamada <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Will, could you please pick this up for 4.7? Maybe with a cc stable.
Thanks.

-- 
Catalin

Re: [PATCH] arm64: add boot image dependencies to not generate invalid images

From: Will Deacon <hidden>
Date: 2016-06-21 13:38:20

On Tue, Jun 21, 2016 at 11:32:17AM +0100, Catalin Marinas wrote:
On Tue, Jun 21, 2016 at 10:44:00AM +0900, Masahiro Yamada wrote:
quoted
I fixed boot image dependencies for arch/arm in commit 3939f3345050
("ARM: 8418/1: add boot image dependencies to not generate invalid
images").

I see a similar problem for arch/arm64; "make -jN Image Image.gz"
would sometimes end up generating bad images where N > 1.

Fix the dependency in arch/arm64/Makefile to avoid the race
between "make Image" and "make Image.*".

Signed-off-by: Masahiro Yamada <redacted>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Will, could you please pick this up for 4.7? Maybe with a cc stable.
Yup, will do.

Will
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help