5 messages, 2 authors, 2016-06-18 · open the first message on its own page
From: Masahiro Yamada <hidden>
Date: 2016-06-15 08:19:11
Masahiro Yamada (2): pinctrl: uniphier: prohibit drive control for pin 61-66 of PH1-LD11 pinctrl: uniphier: fix meaningless drive control offsets drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c | 12 ++++++------ drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) -- 1.9.1
From: Masahiro Yamada <hidden>
Date: 2016-06-15 08:19:13
According to the hardware document, setting the drive control is prohibited for these pins (N-channel Open Drain pins). Set their drive control attribute to "fixed". Signed-off-by: Masahiro Yamada <redacted> --- drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c
index 150942f..608cd73 100644
--- a/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c
+++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-ld11.c@@ -151,22 +151,22 @@ static const struct pinctrl_pin_desc uniphier_ld11_pins[] = { 60, UNIPHIER_PIN_DRV_1BIT, 60, UNIPHIER_PIN_PULL_DOWN), UNIPHIER_PINCTRL_PIN(61, "DMDSDA0", 61, - 61, UNIPHIER_PIN_DRV_1BIT, + -1, UNIPHIER_PIN_DRV_FIXED4, -1, UNIPHIER_PIN_PULL_NONE), UNIPHIER_PINCTRL_PIN(62, "DMDSCL0", 62, - 62, UNIPHIER_PIN_DRV_1BIT, + -1, UNIPHIER_PIN_DRV_FIXED4, -1, UNIPHIER_PIN_PULL_NONE), UNIPHIER_PINCTRL_PIN(63, "SDA0", 63, - 63, UNIPHIER_PIN_DRV_1BIT, + -1, UNIPHIER_PIN_DRV_FIXED4, -1, UNIPHIER_PIN_PULL_NONE), UNIPHIER_PINCTRL_PIN(64, "SCL0", 64, - 64, UNIPHIER_PIN_DRV_1BIT, + -1, UNIPHIER_PIN_DRV_FIXED4, -1, UNIPHIER_PIN_PULL_NONE), UNIPHIER_PINCTRL_PIN(65, "SDA1", 65, - 65, UNIPHIER_PIN_DRV_1BIT, + -1, UNIPHIER_PIN_DRV_FIXED4, -1, UNIPHIER_PIN_PULL_NONE), UNIPHIER_PINCTRL_PIN(66, "SCL1", 66, - 66, UNIPHIER_PIN_DRV_1BIT, + -1, UNIPHIER_PIN_DRV_FIXED4, -1, UNIPHIER_PIN_PULL_NONE), UNIPHIER_PINCTRL_PIN(67, "HIN", 67, -1, UNIPHIER_PIN_DRV_FIXED5,
--
1.9.1
From: Masahiro Yamada <hidden>
Date: 2016-06-15 08:19:48
These are input-only pins. They do not support drive controlling in the first place. Signed-off-by: Masahiro Yamada <redacted> --- drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
index 8c61493..002bd6e 100644
--- a/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c
+++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-pro4.c@@ -138,7 +138,7 @@ static const struct pinctrl_pin_desc uniphier_pro4_pins[] = { 38, UNIPHIER_PIN_DRV_1BIT, 38, UNIPHIER_PIN_PULL_DOWN), UNIPHIER_PINCTRL_PIN(39, "BOOTSWAP", UNIPHIER_PIN_IECTRL_NONE, - 39, UNIPHIER_PIN_DRV_NONE, + -1, UNIPHIER_PIN_DRV_NONE, 39, UNIPHIER_PIN_PULL_UP), UNIPHIER_PINCTRL_PIN(40, "NFD0", UNIPHIER_PIN_IECTRL_NONE, 2, UNIPHIER_PIN_DRV_2BIT,
@@ -639,7 +639,7 @@ static const struct pinctrl_pin_desc uniphier_pro4_pins[] = { 191, UNIPHIER_PIN_DRV_1BIT, 191, UNIPHIER_PIN_PULL_DOWN), UNIPHIER_PINCTRL_PIN(206, "CLK54I", UNIPHIER_PIN_IECTRL_NONE, - 192, UNIPHIER_PIN_DRV_NONE, + -1, UNIPHIER_PIN_DRV_NONE, 192, UNIPHIER_PIN_PULL_DOWN), UNIPHIER_PINCTRL_PIN(207, "YIN0", UNIPHIER_PIN_IECTRL_NONE, 193, UNIPHIER_PIN_DRV_1BIT,
@@ -1005,7 +1005,7 @@ static const struct pinctrl_pin_desc uniphier_pro4_pins[] = { 311, UNIPHIER_PIN_DRV_1BIT, 311, UNIPHIER_PIN_PULL_UP), UNIPHIER_PINCTRL_PIN(328, "DMDISO", UNIPHIER_PIN_IECTRL_NONE, - 312, UNIPHIER_PIN_DRV_NONE, + -1, UNIPHIER_PIN_DRV_NONE, 312, UNIPHIER_PIN_PULL_DOWN), };
--
1.9.1
From: Linus Walleij <hidden>
Date: 2016-06-18 08:02:48
On Wed, Jun 15, 2016 at 10:18 AM, Masahiro Yamada [off-list ref] wrote:
According to the hardware document, setting the drive control is prohibited for these pins (N-channel Open Drain pins). Set their drive control attribute to "fixed". Signed-off-by: Masahiro Yamada <redacted>
Patch applied. Yours, Linus Walleij
From: Linus Walleij <hidden>
Date: 2016-06-18 08:03:42
On Wed, Jun 15, 2016 at 10:18 AM, Masahiro Yamada [off-list ref] wrote:
These are input-only pins. They do not support drive controlling in the first place. Signed-off-by: Masahiro Yamada <redacted>
Patch applied. Yours, Linus Walleij