Re: [PATCH v2 11/23] ARM: dts: armadillo800eva: Fix W=1 dtc warnings

4 messages, 3 authors, 2016-05-24 · open the first message on its own page

Re: [PATCH v2 11/23] ARM: dts: armadillo800eva: Fix W=1 dtc warnings

From: Geert Uytterhoeven <hidden>
Date: 2016-05-23 12:52:20

On Fri, May 20, 2016 at 5:38 PM, Sergei Shtylyov
[off-list ref] wrote:
On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:
quoted
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /regulator at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /i2c at 2 has a unit name, but no reg property

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - No changes.
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
[...]
quoted
@@ -127,7 +127,7 @@
                };
        };

-       i2c2: i2c at 2 {
+       i2c2: i2c2 {
   Not "i2c-2" as in the other patches?
Oops... Thanks for noticing!

Simon: Do you want me to repost the whole series once again, or
can you fix this up while applying?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 11/23] ARM: dts: armadillo800eva: Fix W=1 dtc warnings

From: Simon Horman <horms@verge.net.au>
Date: 2016-05-24 00:13:09

On Mon, May 23, 2016 at 02:52:20PM +0200, Geert Uytterhoeven wrote:
On Fri, May 20, 2016 at 5:38 PM, Sergei Shtylyov
[off-list ref] wrote:
quoted
On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:
quoted
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /regulator at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /i2c at 2 has a unit name, but no reg property

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - No changes.
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
[...]
quoted
@@ -127,7 +127,7 @@
                };
        };

-       i2c2: i2c at 2 {
+       i2c2: i2c2 {
   Not "i2c-2" as in the other patches?
Oops... Thanks for noticing!

Simon: Do you want me to repost the whole series once again, or
can you fix this up while applying?
I'll just fix it up.
No need to repost for this.

Re: [PATCH v2 11/23] ARM: dts: armadillo800eva: Fix W=1 dtc warnings

From: Simon Horman <horms@verge.net.au>
Date: 2016-05-24 00:33:57

On Tue, May 24, 2016 at 09:13:09AM +0900, Simon Horman wrote:
On Mon, May 23, 2016 at 02:52:20PM +0200, Geert Uytterhoeven wrote:
quoted
On Fri, May 20, 2016 at 5:38 PM, Sergei Shtylyov
[off-list ref] wrote:
quoted
On 05/20/2016 10:10 AM, Geert Uytterhoeven wrote:
quoted
Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
Warning (unit_address_vs_reg): Node /regulator at 0 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 1 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 2 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /regulator at 3 has a unit name, but no reg property
Warning (unit_address_vs_reg): Node /i2c at 2 has a unit name, but no reg property

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
  - No changes.
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 2c82dab2b6f45f9c..b3f0ac4b99bd5a3d 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
[...]
quoted
@@ -127,7 +127,7 @@
                };
        };

-       i2c2: i2c at 2 {
+       i2c2: i2c2 {
   Not "i2c-2" as in the other patches?
Oops... Thanks for noticing!

Simon: Do you want me to repost the whole series once again, or
can you fix this up while applying?
I'll just fix it up.
No need to repost for this.
I have queued this up with the above hunk changed to the following.
Please check the resulting patch and let me know if I've messed things up
somehow.
@@ -127,7 +127,7 @@
 		};
 	};
 
-	i2c2: i2c at 2 {
+	i2c2: i2c-2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 		compatible = "i2c-gpio";

Re: [PATCH v2 11/23] ARM: dts: armadillo800eva: Fix W=1 dtc warnings

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2016-05-24 07:37:04

Hi Simon,

On Tue, May 24, 2016 at 2:33 AM, Simon Horman [off-list ref] wrote:
quoted
quoted
quoted
quoted
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
quoted hunk
I have queued this up with the above hunk changed to the following.
Please check the resulting patch and let me know if I've messed things up
somehow.
@@ -127,7 +127,7 @@
                };
        };

-       i2c2: i2c at 2 {
+       i2c2: i2c-2 {
Thanks, looks fine.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help