From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
---
arch/arm64/kernel/image.h | 2 ++
1 file changed, 2 insertions(+)
Hi Thierry,
On 15 February 2016 at 20:17, Thierry Reding [off-list ref] wrote:
quoted hunk
From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
---
arch/arm64/kernel/image.h | 2 ++
1 file changed, 2 insertions(+)
On Mon, Feb 15, 2016 at 08:23:22PM +0100, Ard Biesheuvel wrote:
Hi Thierry,
On 15 February 2016 at 20:17, Thierry Reding [off-list ref] wrote:
quoted
From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
---
arch/arm64/kernel/image.h | 2 ++
1 file changed, 2 insertions(+)
To align with the existing code, we should use __pi_strnlen here, and
declare the asm version of strnlen with ENDPIPROC()
Yes, you're absolutely right. For some reason I had missed the ARM64
implementation of strnlen() in the grep output. Sent a v2 now which is
consistent with the existing code.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160216/a3e4386c/attachment.sig>
From: Will Deacon <hidden> Date: 2016-02-15 19:27:46
On Mon, Feb 15, 2016 at 08:17:36PM +0100, Thierry Reding wrote:
quoted hunk
From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
---
arch/arm64/kernel/image.h | 2 ++
1 file changed, 2 insertions(+)
Shouldn't this refer to __pi_strnlen once we've established that our
strnlen implementation is position independent? It looks like it is, so
you just need to s/ENDPROC/ENDPIPROC/ over there to get the symbol
defined.
Will
From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
---
Changes in v2:
- mark strnlen() position independent and refer to __pi_strnlen
arch/arm64/kernel/image.h | 1 +
arch/arm64/lib/strnlen.S | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
On 16 February 2016 at 11:16, Thierry Reding [off-list ref] wrote:
From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
Reviewed-by: Ard Biesheuvel <redacted>
quoted hunk
---
Changes in v2:
- mark strnlen() position independent and refer to __pi_strnlen
arch/arm64/kernel/image.h | 1 +
arch/arm64/lib/strnlen.S | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
From: Will Deacon <hidden> Date: 2016-02-16 10:32:54
On Tue, Feb 16, 2016 at 11:16:31AM +0100, Thierry Reding wrote:
From: Thierry Reding <redacted>
Changes introduced in the upstream version of libfdt pulled in by commit
91feabc2e224 ("scripts/dtc: Update to upstream commit b06e55c88b9b") use
the strnlen() function, which isn't currently available to the EFI name-
space. Add it to the EFI namespace to avoid a linker error.
Cc: Ard Biesheuvel <redacted>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <redacted>
Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Thierry Reding <redacted>
---
Changes in v2:
- mark strnlen() position independent and refer to __pi_strnlen
Thanks, I'll queue this on the arm64 fixes branch.
Will