Commit b9b32bf70f2f ("ARM: use linker magic for vectors and vector stubs")
introduced new global definitions of __vectors_start and __stubs_start,
and changed the existing ones to have internal linkage only. However, these
symbols are still visible to kallsyms, and due to the way the .vectors and
.stubs sections are emitted at the base of the VMA space, these duplicate
definitions have conflicting values.
$ nm -n vmlinux |grep -E __vectors\|__stubs
00000000 t __vectors_start
00001000 t __stubs_start
c0e77000 T __vectors_start
c0e77020 T __stubs_start
This is completely harmless by itself, since the wrong values are local
symbols that cannot be referenced by other object files directly. However,
since these symbols are also listed in the kallsyms symbol table in some
cases (i.e., CONFIG_KALLSYMS_ALL=y and CONFIG_XIP_KERNEL=y), having these
conflicting values can be confusing. So either remove them, or make them
strictly local.
Signed-off-by: Ard Biesheuvel <redacted>
---
This is a separate fix for the duplicate symbols based on v4.5-rc2,
so that it can be applied separately if desired. In that case, I will
rebase my kallsyms series onto this patch.
arch/arm/kernel/entry-armv.S | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
This is completely harmless by itself, since the wrong values are local
symbols that cannot be referenced by other object files directly. However,
since these symbols are also listed in the kallsyms symbol table in some
cases (i.e., CONFIG_KALLSYMS_ALL=y and CONFIG_XIP_KERNEL=y), having these
conflicting values can be confusing. So either remove them, or make them
strictly local.
Signed-off-by: Ard Biesheuvel <redacted>
---
This is a separate fix for the duplicate symbols based on v4.5-rc2,
so that it can be applied separately if desired. In that case, I will
rebase my kallsyms series onto this patch.
arch/arm/kernel/entry-armv.S | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Tested with ARCH_R7S72100 with CONFIG_XIP_KERNEL=y and CONFIG_XIP_KERNEL=n
Duplicate symbols are gone, and boots fine (given the other patches from "[PATCH 0/3] kallsyms: remove special handling for CONFIG_ARM" for the CONFIG_XIP_KERNEL=y case)
Acked-by: Chris Brandt <chris.brandt@renesas.com>
From: Nicolas Pitre <hidden> Date: 2016-02-04 16:49:34
On Thu, 4 Feb 2016, Ard Biesheuvel wrote:
Commit b9b32bf70f2f ("ARM: use linker magic for vectors and vector stubs")
introduced new global definitions of __vectors_start and __stubs_start,
and changed the existing ones to have internal linkage only. However, these
symbols are still visible to kallsyms, and due to the way the .vectors and
.stubs sections are emitted at the base of the VMA space, these duplicate
definitions have conflicting values.
$ nm -n vmlinux |grep -E __vectors\|__stubs
00000000 t __vectors_start
00001000 t __stubs_start
c0e77000 T __vectors_start
c0e77020 T __stubs_start
This is completely harmless by itself, since the wrong values are local
symbols that cannot be referenced by other object files directly. However,
since these symbols are also listed in the kallsyms symbol table in some
cases (i.e., CONFIG_KALLSYMS_ALL=y and CONFIG_XIP_KERNEL=y), having these
conflicting values can be confusing. So either remove them, or make them
strictly local.
Signed-off-by: Ard Biesheuvel <redacted>
Acked-by: Nicolas Pitre <redacted>
quoted hunk
---
This is a separate fix for the duplicate symbols based on v4.5-rc2,
so that it can be applied separately if desired. In that case, I will
rebase my kallsyms series onto this patch.
arch/arm/kernel/entry-armv.S | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
On 4 February 2016 at 17:49, Nicolas Pitre [off-list ref] wrote:
On Thu, 4 Feb 2016, Ard Biesheuvel wrote:
quoted
Commit b9b32bf70f2f ("ARM: use linker magic for vectors and vector stubs")
introduced new global definitions of __vectors_start and __stubs_start,
and changed the existing ones to have internal linkage only. However, these
symbols are still visible to kallsyms, and due to the way the .vectors and
.stubs sections are emitted at the base of the VMA space, these duplicate
definitions have conflicting values.
$ nm -n vmlinux |grep -E __vectors\|__stubs
00000000 t __vectors_start
00001000 t __stubs_start
c0e77000 T __vectors_start
c0e77020 T __stubs_start
This is completely harmless by itself, since the wrong values are local
symbols that cannot be referenced by other object files directly. However,
since these symbols are also listed in the kallsyms symbol table in some
cases (i.e., CONFIG_KALLSYMS_ALL=y and CONFIG_XIP_KERNEL=y), having these
conflicting values can be confusing. So either remove them, or make them
strictly local.
Signed-off-by: Ard Biesheuvel <redacted>